Skip to content

Commit 59cf9fd

Browse files
timosachsenbergtimosachsenbergclaude
authored
Feature/add libcurl dependency (#175)
* build: add libcurl-dev to Dockerfiles OpenMS core library now uses libcurl instead of Qt Network for HTTP operations. Add the development packages so the build can find curl headers and libraries. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * build: add -fPIC to static libcurl build Add CMAKE_POSITION_INDEPENDENT_CODE=ON to the curl cmake configuration. Without this, the static libcurl.a contains position-dependent relocations (R_X86_64_32S) that cannot be linked into libOpenMS.so, causing linker failures on Linux wheel builds. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: timosachsenberg <sachsenb@ibminode05.Cs.Uni-Tuebingen.De> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 3ab70e9 commit 59cf9fd

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

libraries.cmake/curl.cmake

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ execute_process(COMMAND ${CMAKE_COMMAND}
4343
-D CMAKE_BUILD_TYPE=Release
4444
-D CMAKE_INSTALL_PREFIX=${PROJECT_BINARY_DIR}
4545
-D BUILD_SHARED_LIBS=${BUILD_SHARED_LIBRARIES}
46+
-D CMAKE_POSITION_INDEPENDENT_CODE=ON
4647
-D BUILD_CURL_EXE=OFF
4748
-D BUILD_TESTING=OFF
4849
-D CURL_DISABLE_LDAP=ON

0 commit comments

Comments
 (0)