jsonlib: auto_ptr causes FTBFS

[leamas]

the jsonlib library uses auto_ptr<>; this does not compile on current C++ standards including the commonly used C++17

[quinton-hoole]

@leamas The dirty fix in #50 appears to cause problems building on windows.

C:\project\opencpn\plugin_src\opencpn-libs\jsonlib\src\json_writer.cpp(42,14): error C2039: 'auto_ptr': is not a member of 'std' [C:\project\opencpn\plugin_src\build\opencpn-libs\jsonlib\JSONLIB.vcxproj] [C:\project\opencpn\plugin_src\build\tarball-build.vcxproj]
        C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.44.35207\include\set(22,1):
        see declaration of 'std'
    

See https://ci.appveyor.com/project/quinton-hoole/weather-routing-pi/builds/53550232.

Strangely enough this exact CI build succeeded yesterday, but failed today.

Here is the CI build that succeeded yesterday:

https://ci.appveyor.com/project/quinton-hoole/weather-routing-pi/builds/53539454

Incidentally, build 53550232 referenced above is an example of a CI build (in this case using AppVeyor, and based on the shipdriver templates) which failed but reported success (and which I mentioned in a different context). See:

Traceback (most recent call last):
  File "C:\project\opencpn\plugin_src\build\ldd.py", line 2, in <module>
    lib = glob.glob("app/*/plugins/*.dll")[0] 
          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^
IndexError: list index out of range
...
Error: Invalid value for 'PACKAGE_FILE': File 'WeatherRouting-2.1.1+41.3aad69e_msvc-wx32-10-x86.tar.gz' does not exist.
...
Build success

[leamas]

Did I do this "banging head to table"

Seems like some #ifdef slipped through the net. auto_ptr is removed from current c++ specs, this is the core problem. It can always be replaced with unique_ptr. There are some corner cases, but they are caught by the compiler.

Will have a look over the day. Thanks for reporting!

[leamas]

This is about branches and such. The #50 fix was applied to the opencpn-libs devel branch, and this is not what is used in the SD template.

I have pushed this commit to the opencpn-libs main branch. You will need to update opencpn-libs to the new tip @823c5d8. i.e., the tip of the submodule branch main. Let me know if you need help doing this.