[question]: when creating a Notification should `isIos` default to `true`?

[scottbartell]

How can we help?

Is it intentional for isIos to default to true when creating a Notification?

For example, this request (that doesn't specify is_ios) results in an API request with a body where isIos is set to true:

notification = OneSignal::Notification.new({
  app_id: 'YOUR APP ID',
  include_external_user_ids: [user.id],
  channel_for_external_user_ids: 'push',
  contents: {
    en: body
  },
})
one_signal_client.create_notification(notification)

It looks like it's because of this default: https://github.com/OneSignal/onesignal-ruby-api/blob/master/lib/onesignal/models/notification.rb#L793

Code of Conduct

• I agree to follow this project's Code of Conduct

[kesheshyan]

Hey @scottbartell, thanks for the question. We are about to release an update that should mitigate this issue. I will update this thread when it's done. Thanks!

[FinnLawrence]

As far as I can see this is still happening in the current version.

isIos silently defaults to true, meaning my notifications weren't targeting Android at all - since targeting any platform turns off the others in the API.

Need to add both is_ios and is_android as true in the notification payload to get it sending to both platforms

[sherwinski]

Thanks for the callout @FinnLawrence. I'm unfamiliar with why this default was added so let me dig into it a bit more.

[sherwinski]

Hey @FinnLawrence, it looks like this still needs to be changed to target more than just iOS by default. Seeing as it would be a breaking change, I've made a note internally to add this to the project's next major release.

On second look, this seems to be fixed already in the latest release (v2.2.0). @FinnLawrence can you check and see if this is still an issue for you?

[sherwinski]

Closing this as it already seems to be fixed. Please feel free to open a new issue if you have further questions or concers. Thanks