fix: only createUserOnServer on logout if there are any subscriptions (#1422)

Author: sherwinski

package.json

@@ -85,7 +85,7 @@
     },
     {
       "path": "./build/releases/OneSignalSDK.page.es6.js",
-      "limit": "46.23 kB",
+      "limit": "46.24 kB",
       "gzip": true
     },
     {

src/page/managers/LoginManager.test.ts

@@ -63,8 +63,20 @@ describe('LoginManager', () => {
     );
   });
 
-  test('logout: with external id resets models and creates anonymous user', async () => {
+  test('logout: with external id and no subscriptions resets models and skips user creation', async () => {
     await updateIdentityModel('external_id', 'abc');
+    await LoginManager.logout();
+    expect(createUserOnServerSpy).not.toHaveBeenCalled();
+  });
+
+  test('logout: with external id and a subscription resets models and creates anonymous user', async () => {
+    await updateIdentityModel('external_id', 'abc');
+    const mockSub = { id: 'sub-id' } as SubscriptionModel;
+    vi.spyOn(
+      OneSignal._coreDirector._subscriptionModelStore,
+      '_list',
+    ).mockReturnValue([mockSub]);
+
     await LoginManager.logout();
     expect(createUserOnServerSpy).toHaveBeenCalled();
   });

src/page/managers/LoginManager.ts

@@ -93,9 +93,15 @@ export default class LoginManager {
     if (!identityModel._externalId)
       return Log._debug('Logout: User is not logged in, skipping logout');
 
+    const hasAnySubscription =
+      OneSignal._coreDirector._subscriptionModelStore._list().length > 0;
+
     resetUserModels();
 
-    // create a new anonymous user
-    return createUserOnServer();
+    // Only create an anonymous user if there is a subscription to associate with it.
+    // Without a subscription, there is nothing meaningful to register on the server.
+    if (hasAnySubscription) {
+      return createUserOnServer();
+    }
   }
 }