-
Notifications
You must be signed in to change notification settings - Fork 375
[Bug]: 5.7.x fails builds with R8/Proguard #2576
Copy link
Copy link
Closed
Description
What happened?
We get the following build failure with release builds (Proguard/R8) when updating to 5.7.x (including 5.7.2):
Missing classes detected while running R8. Please add the missing classes or apply additional keep rules that are generated in ...\missing_rules.txt.
Missing class com.fasterxml.jackson.core.JsonFactory (referenced from: com.fasterxml.jackson.core.JsonFactory io.opentelemetry.exporter.internal.marshal.JsonSerializer.JSON_FACTORY and 2 other contexts)
The workaround (according to AI) is to add these to your local proguardr-rules.pro:
# OpenTelemetry - Jackson is an optional dependency not included on Android
-dontwarn com.fasterxml.jackson.core.JsonFactory
-dontwarn com.fasterxml.jackson.core.JsonGenerator
But it seems like the library should include any needed rules in its consumer-rules.pro
Steps to reproduce?
Update from 5.6.2 to 5.7.2
Your build now fails.What did you expect to happen?
I expected to be able to build my app. without hunting down proguard rules to add. as a workaround.
OneSignal Android SDK version
5.7.2
Android version
15
Specific Android models
Relevant log output
Missing classes detected while running R8. Please add the missing classes or apply additional keep rules that are generated in ...\missing_rules.txt.
Missing class com.fasterxml.jackson.core.JsonFactory (referenced from: com.fasterxml.jackson.core.JsonFactory io.opentelemetry.exporter.internal.marshal.JsonSerializer.JSON_FACTORY and 2 other contexts)Code of Conduct
- I agree to follow this project's Code of Conduct
Reactions are currently unavailable