Skip to content

[Question]: android:exported="true" flag #2540

@OS-pedrogustavobilro

Description

@OS-pedrogustavobilro

How can we help?

Hey everyone! Hope the message finds you well.

I'm inquiring about a topic that was mentioned in an issue closed some time ago, that as mentioned in the last comment, has resurfaced: #1135 (comment)

With regards to two specific components that are marked as exported in the SDK's Manifest: com.onesignal.NotificationOpenedActivityHMS and com.onesignal.notifications.activities.NotificationOpenedActivity. It's not clear to me why do these components need to be exported.

At least for NotificationOpenedActivity I tested replacing it as android:exported="false" in the merged manifest in an application, and it still works fine across different Android versions (tested 9, 12, and 16), which makes sense if the one place it is called is inside the SDK - in which case it wouldn't need to be exported. But I wanted to get confirmation from the OneSignal devs before making this change in the app, to avoid unforeseen issues.

Let me know if you need any more information, thank you!

Code of Conduct

  • I agree to follow this project's Code of Conduct

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions