feat: tel crash reporting (#2511)

Co-authored-by: Josh Kasten <[email protected]>
Co-authored-by: AR Abdul Azeez <[email protected]>
Co-authored-by: Cursor <[email protected]>

Author: 4 people

OneSignalSDK/build.gradle

@@ -14,8 +14,8 @@ buildscript {
         huaweiAgconnectVersion = '1.9.1.304'
         huaweiHMSPushVersion = '6.3.0.304'
         huaweiHMSLocationVersion = '4.0.0.300'
-        kotlinVersion = '1.9.25'
-        dokkaVersion = '1.9.10' // Dokka version compatible with Kotlin 1.9.25
+        kotlinVersion = '2.2.0'
+        dokkaVersion = '1.9.10'
         coroutinesVersion = '1.7.3'
         kotestVersion = '5.8.0'
         ioMockVersion = '1.13.2'
@@ -25,6 +25,10 @@ buildscript {
         ktlintVersion = '0.50.0' // Used by Spotless for Kotlin formatting (compatible with Kotlin 1.7.10)
         spotlessVersion = '6.25.0'
         tdunningJsonForTest = '1.0' // DO NOT upgrade for tests, using an old version so it matches AOSP
+        // OpenTelemetry versions
+        opentelemetryBomVersion = '1.55.0'
+        opentelemetrySemconvVersion = '1.37.0'
+        opentelemetryDiskBufferingVersion = '1.51.0-alpha'
 
         sharedRepos = {
             google()
@@ -45,11 +49,9 @@ buildscript {
         ]
     }
 
-    buildscript {
-        repositories sharedRepos
-        dependencies {
-            classpath sharedDeps
-        }
+    repositories sharedRepos
+    dependencies {
+        classpath sharedDeps
     }
 }
 

OneSignalSDK/detekt/detekt-baseline-core.xml

@@ -91,7 +91,7 @@ comments:
   UndocumentedPublicFunction:
     active: true
     excludes: ['**/test/**', '**/androidTest/**', '**/testhelpers/**']
-  
+
   EndOfSentenceFormat:
     active: false
     endOfSentenceFormat: ([.?!][ \t\n\r\f<])|([.?!:]$)

OneSignalSDK/detekt/detekt-config.yml

@@ -82,6 +82,8 @@ dependencies {
         }
     }
 
+    // Otel module dependency
+    implementation(project(':OneSignal:otel'))
     testImplementation(project(':OneSignal:testhelpers'))
 
     testImplementation("io.kotest:kotest-runner-junit5:$kotestVersion")

OneSignalSDK/onesignal/core/build.gradle

@@ -1,4 +1,9 @@
-<manifest xmlns:android="http://schemas.android.com/apk/res/android">
+<manifest xmlns:android="http://schemas.android.com/apk/res/android"
+    xmlns:tools="http://schemas.android.com/tools">
+
+    <!-- Override otel module's minSdk requirement (26) since we have runtime checks -->
+    <!-- The otel module is only used on SDK 26+, so this is safe -->
+    <uses-sdk tools:overrideLibrary="com.onesignal.otel" />
 
     <!-- Required so the device can access the internet. -->
     <uses-permission android:name="android.permission.INTERNET" />

OneSignalSDK/onesignal/core/src/main/AndroidManifest.xml

@@ -61,7 +61,7 @@ object JSONUtils {
             try {
                 val value = jsonObject.opt(key)
                 if (value is JSONArray || value is JSONObject) {
-                    Logging.error("Omitting key '$key'! sendTags DO NOT supported nested values!")
+                    Logging.warn("Omitting key '$key'! sendTags DO NOT supported nested values!")
                 } else if (jsonObject.isNull(key) || "" == value) {
                     result[key] = ""
                 } else {

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/common/JSONUtils.kt

@@ -33,6 +33,7 @@ import com.onesignal.core.internal.purchases.impl.TrackGooglePurchase
 import com.onesignal.core.internal.startup.IStartableService
 import com.onesignal.core.internal.time.ITime
 import com.onesignal.core.internal.time.impl.Time
+import com.onesignal.debug.internal.crash.OneSignalCrashUploaderWrapper
 import com.onesignal.inAppMessages.IInAppMessagesManager
 import com.onesignal.inAppMessages.internal.MisconfiguredIAMManager
 import com.onesignal.location.ILocationManager
@@ -81,6 +82,9 @@ internal class CoreModule : IModule {
         // Purchase Tracking
         builder.register<TrackGooglePurchase>().provides<IStartableService>()
 
+        // Crash Uploader (crash handler is initialized directly in OneSignalImp for early initialization)
+        builder.register<OneSignalCrashUploaderWrapper>().provides<IStartableService>()
+
         // Register dummy services in the event they are not configured. These dummy services
         // will throw an error message if the associated functionality is attempted to be used.
         builder.register<MisconfiguredNotificationsManager>().provides<INotificationsManager>()

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/core/CoreModule.kt

@@ -2,7 +2,7 @@ package com.onesignal.core.internal.backend
 
 import org.json.JSONArray
 
-interface IParamsBackendService {
+internal interface IParamsBackendService {
     /**
      * Retrieve the configuration parameters for the [appId] and optional [subscriptionId].
      *
@@ -20,7 +20,8 @@ interface IParamsBackendService {
     ): ParamsObject
 }
 
-class ParamsObject(
+@Suppress("LongParameterList")
+internal class ParamsObject(
     var googleProjectNumber: String? = null,
     var enterprise: Boolean? = null,
     var useIdentityVerification: Boolean? = null,
@@ -36,9 +37,10 @@ class ParamsObject(
     var opRepoExecutionInterval: Long? = null,
     var influenceParams: InfluenceParamsObject,
     var fcmParams: FCMParamsObject,
+    val remoteLoggingParams: RemoteLoggingParamsObject,
 )
 
-class InfluenceParamsObject(
+internal class InfluenceParamsObject(
     val indirectNotificationAttributionWindow: Int? = null,
     val notificationLimit: Int? = null,
     val indirectIAMAttributionWindow: Int? = null,
@@ -48,8 +50,13 @@ class InfluenceParamsObject(
     val isUnattributedEnabled: Boolean? = null,
 )
 
-class FCMParamsObject(
+internal class FCMParamsObject(
     val projectId: String? = null,
     val appId: String? = null,
     val apiKey: String? = null,
 )
+
+internal class RemoteLoggingParamsObject(
+    val logLevel: com.onesignal.debug.LogLevel? = null,
+    val isEnabled: Boolean = logLevel != null,
+)

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/core/internal/backend/IParamsBackendService.kt

@@ -11,6 +11,7 @@ import com.onesignal.core.internal.backend.FCMParamsObject
 import com.onesignal.core.internal.backend.IParamsBackendService
 import com.onesignal.core.internal.backend.InfluenceParamsObject
 import com.onesignal.core.internal.backend.ParamsObject
+import com.onesignal.core.internal.backend.RemoteLoggingParamsObject
 import com.onesignal.core.internal.http.CacheKeys
 import com.onesignal.core.internal.http.IHttpClient
 import com.onesignal.core.internal.http.impl.OptionalHeaders
@@ -57,6 +58,16 @@ internal class ParamsBackendService(
                 )
         }
 
+        // Process Remote Logging params
+        var remoteLoggingParams: RemoteLoggingParamsObject? = null
+        responseJson.expandJSONObject("logging_config") {
+            val logLevel = LogLevel.fromString(it.safeString("log_level"))
+            remoteLoggingParams =
+                RemoteLoggingParamsObject(
+                    logLevel = logLevel,
+                )
+        }
+
         return ParamsObject(
             googleProjectNumber = responseJson.safeString("android_sender_id"),
             enterprise = responseJson.safeBool("enterp"),
@@ -75,6 +86,7 @@ internal class ParamsBackendService(
             opRepoExecutionInterval = responseJson.safeLong("oprepo_execution_interval"),
             influenceParams = influenceParams ?: InfluenceParamsObject(),
             fcmParams = fcmParams ?: FCMParamsObject(),
+            remoteLoggingParams = remoteLoggingParams ?: RemoteLoggingParamsObject(),
         )
     }
 

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/core/internal/backend/impl/ParamsBackendService.kt

@@ -186,7 +186,7 @@ internal class BackgroundManager(
         } catch (e: NullPointerException) {
             // Catch for buggy Oppo devices
             // https://github.com/OneSignal/OneSignal-Android-SDK/issues/487
-            Logging.error(
+            Logging.info(
                 "scheduleSyncServiceAsJob called JobScheduler.jobScheduler which " +
                     "triggered an internal null Android error. Skipping job.",
                 e,