Version bump 2.4.9: Allow delete person if pnr is unknown in cpr direct.

Author: heiniovason

PART/Source/Core/Config/Properties/AssemblyInfo.cs

@@ -75,5 +75,5 @@
 // You can specify all the values or you can default the Build and Revision Numbers 
 // by using the '*' as shown below:
 // [assembly: AssemblyVersion("1.0.*")]
-[assembly: AssemblyVersion("2.4.8.0")]
-[assembly: AssemblyFileVersion("2.4.8.0")]
+[assembly: AssemblyVersion("2.4.9.0")]
+[assembly: AssemblyFileVersion("2.4.9.0")]

PART/Source/Core/Utilities/Constants.cs

@@ -86,8 +86,8 @@ public sealed class Versioning
             public static readonly int Minor = 0;
 
             // TODO: Set version manually in Config project
-            public const string AssemblyVersion = "2.4.8.0";
-            public const string AssemblyFileVersion = "2.4.8.0";
+            public const string AssemblyVersion = "2.4.9.0";
+            public const string AssemblyFileVersion = "2.4.9.0";
         }
 
         public static readonly Guid EventBrokerApplicationId = new Guid("{C98F9BE7-2DDE-404a-BAB5-5A7B1BBC3063}");

PART/Source/CprBroker/CPRDirect/CPRDirectClientDataProvider.cs

@@ -127,7 +127,13 @@ public bool RemoveSubscription(PersonIdentifier personIdentifier)
                     return true;
                 } else
                 {
-                    throw new Exception(error);
+                    // throw new Exception(error);
+
+                    // Throwing an exception will cancel a person removal attempt.
+                    // We do not want this, e.g. if the error occurs solely because CPR Direct does not recognize a given cpr no.
+                    // BUT we do need to log the error in case of other scenarios.
+                    Admin.LogError(error);
+                    return true;
                 }
             }
             else

PART/Source/CprBroker/WixInstaller/Product.wxs

@@ -2,7 +2,7 @@
 
 <Wix xmlns="http://schemas.microsoft.com/wix/2006/wi" xmlns:util="http://schemas.microsoft.com/wix/UtilExtension" >
 
-  <Product Id="632b6f92-1383-4138-8d75-5a153d2c96c4" Name="Cpr Broker" Language="1033" Version="2.4.8.0" Manufacturer="OS2 - Public Digitalization Network" UpgradeCode="FF0F6556-3323-43A8-9AB3-E567BEF13F6A">
+<Product Id="85e0afd9-db30-4ce6-8fd0-b69c9fceb5dd" Name="Cpr Broker" Language="1033" Version="2.4.9.0" Manufacturer="OS2 - Public Digitalization Network" UpgradeCode="FF0F6556-3323-43A8-9AB3-E567BEF13F6A">
 
     <Package InstallerVersion="200" Compressed="yes" InstallScope="perMachine"/> <!-- InstallScope="perMachine" requires elevated privileges. -->
     <Media Id="1" Cabinet="media1.cab" EmbedCab="yes" />
@@ -27,10 +27,10 @@
     -->
     <Upgrade Id="FF0F6556-3323-43A8-9AB3-E567BEF13F6A">
       <!--Detect old version -->
-      <UpgradeVersion Maximum="2.4.8.0" IncludeMaximum="no" Property="OLDER_VERSION_DETECTED" OnlyDetect="yes" MigrateFeatures="yes" />
+    <UpgradeVersion Maximum="2.4.9.0" IncludeMaximum="no" Property="OLDER_VERSION_DETECTED" OnlyDetect="yes" MigrateFeatures="yes" />
 
       <!--Detect newer versions, set a property that triggers a condition failure -->
-      <UpgradeVersion Minimum="2.4.8.0" IncludeMinimum="no" Property="NEWER_VERSION_DETECTED" OnlyDetect="yes" />
+      <UpgradeVersion Minimum="2.4.9.0" IncludeMinimum="no" Property="NEWER_VERSION_DETECTED" OnlyDetect="yes" />
     </Upgrade>
 
     <!-- Special detection for 2.2.2 buggy upgrade code-->