#14542 Summary: Assign unique case ids when importing multiple cases

Summary cases are created and given a case id before they are added to the
project. The id search only sees cases already in the project, so every case
in a batch import was given the same id.

The Data Sources tree stores the owning case id in each summary address, and
all lookups resolve to the first case with that id. Selecting the same vector
from several cases therefore produced a single curve, and dropping a vector
from one of the other cases hit the duplicate check and did nothing.

Author: magnesj

ApplicationLibCode/ProjectDataModel/RimProject.cpp

@@ -555,15 +555,23 @@ void RimProject::setProjectFileNameAndUpdateDependencies( const QString& project
 //--------------------------------------------------------------------------------------------------
 void RimProject::assignCaseIdToSummaryCase( RimSummaryCase* summaryCase )
 {
-    if ( summaryCase )
+    assignCaseIdsToSummaryCases( { summaryCase } );
+}
+
+//--------------------------------------------------------------------------------------------------
+///
+//--------------------------------------------------------------------------------------------------
+void RimProject::assignCaseIdsToSummaryCases( const std::vector<RimSummaryCase*>& summaryCases )
+{
+    int nextValidId = 1;
+    for ( RimSummaryCase* s : allSummaryCases() )
     {
-        int nextValidId = 1;
-        for ( RimSummaryCase* s : allSummaryCases() )
-        {
-            nextValidId = std::max( nextValidId, s->caseId() + 1 );
-        }
+        nextValidId = std::max( nextValidId, s->caseId() + 1 );
+    }
 
-        summaryCase->setCaseId( nextValidId );
+    for ( RimSummaryCase* summaryCase : summaryCases )
+    {
+        if ( summaryCase ) summaryCase->setCaseId( nextValidId++ );
     }
 }
 

ApplicationLibCode/ProjectDataModel/RimProject.h

@@ -132,6 +132,7 @@ class RimProject : public caf::PdmDocument
     void assignViewIdToView( Rim3dView* view );
     void assignPlotIdToPlotWindow( RimPlotWindow* plotWindow );
     void assignCaseIdToSummaryCase( RimSummaryCase* summaryCase );
+    void assignCaseIdsToSummaryCases( const std::vector<RimSummaryCase*>& summaryCases );
     void assignIdToEnsemble( RimSummaryEnsemble* summaryCaseCollection );
 
     [[nodiscard]] std::vector<RimCase*> allGridCases() const;

ApplicationLibCode/ProjectDataModel/Summary/RimSummaryCaseMainCollection.cpp

@@ -755,7 +755,6 @@ std::vector<RimSummaryCase*>
                     }
 
                     newSumCase->setSummaryHeaderFileName( smspecFileName );
-                    project->assignCaseIdToSummaryCase( newSumCase );
 
                     sumCases.push_back( newSumCase );
                 }
@@ -772,6 +771,10 @@ std::vector<RimSummaryCase*>
         QCoreApplication::processEvents( QEventLoop::ExcludeUserInputEvents );
     }
 
+    // Assign case ids for the complete set of new cases. The cases are not yet part of the project, so the ids must be
+    // assigned in one operation to make sure they are unique. See https://github.com/OPM/ResInsight/issues/14542
+    project->assignCaseIdsToSummaryCases( sumCases );
+
     RimSummaryCaseMainCollection::loadSummaryCaseData( sumCases, readStateFromFirstFile );
 
     return sumCases;

ApplicationLibCode/UnitTests/RimSummaryCaseMainCollection-Test.cpp

@@ -4,13 +4,15 @@
 
 #include "RimDeltaSummaryEnsemble.h"
 #include "RimMockSummaryCase.h"
+#include "RimProject.h"
 #include "RimSummaryCaseMainCollection.h"
 #include "RimSummaryCaseUpdateBatch.h"
 #include "RimSummaryEnsemble.h"
 
 #include "cafPdmPointer.h"
 
 #include <algorithm>
+#include <set>
 #include <vector>
 
 //--------------------------------------------------------------------------------------------------
@@ -71,3 +73,28 @@ TEST( RimSummaryCaseMainCollection, RemoveCases_NoDanglingInCallerVector )
     delete ensemble1;
     delete ensemble2;
 }
+
+//--------------------------------------------------------------------------------------------------
+/// Summary cases are created before they are added to the project. Case ids must be assigned for the
+/// complete set of new cases, as cases not yet part of the project are invisible to the id search.
+/// https://github.com/OPM/ResInsight/issues/14542
+//--------------------------------------------------------------------------------------------------
+TEST( RimSummaryCaseMainCollection, AssignUniqueCaseIdsToCasesNotInProject )
+{
+    std::vector<RimSummaryCase*> newCases = { createMockCase( 0 ), createMockCase( 1 ), createMockCase( 2 ) };
+
+    RimProject::current()->assignCaseIdsToSummaryCases( newCases );
+
+    std::set<int> caseIds;
+    for ( auto* summaryCase : newCases )
+    {
+        caseIds.insert( summaryCase->caseId() );
+    }
+
+    EXPECT_EQ( newCases.size(), caseIds.size() );
+
+    for ( auto* summaryCase : newCases )
+    {
+        delete summaryCase;
+    }
+}