Skip to content

Commit 14fdec3

Browse files
committed
Fix FxCop warnings under Release
1 parent 1d0f0bf commit 14fdec3

File tree

2 files changed

+22
-9
lines changed

2 files changed

+22
-9
lines changed

src/Microsoft.Restier.EntityFramework/Model/ModelProducer.cs

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -71,10 +71,7 @@ private static IDictionary<PrimitiveTypeKind, EdmPrimitiveTypeKind>
7171
{ PrimitiveTypeKind.Time, EdmPrimitiveTypeKind.Duration }
7272
};
7373

74-
static ModelProducer()
75-
{
76-
Instance = new ModelProducer();
77-
}
74+
private static IModelBuilder instance;
7875

7976
private ModelProducer()
8077
{
@@ -83,7 +80,18 @@ private ModelProducer()
8380
/// <summary>
8481
/// Gets the single instance of this model producer.
8582
/// </summary>
86-
public static ModelProducer Instance { get; private set; }
83+
public static IModelBuilder Instance
84+
{
85+
get
86+
{
87+
if (instance == null)
88+
{
89+
instance = new ModelProducer();
90+
}
91+
92+
return instance;
93+
}
94+
}
8795

8896
/// <inheritdoc/>
8997
public Task<IEdmModel> GetModelAsync(InvocationContext context, CancellationToken cancellationToken)

src/Microsoft.Restier.WebApi/Routing/RestierRoutingConvention.cs

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -115,13 +115,18 @@ private static bool HasControllerForEntitySetOrSingleton(
115115
ODataPathSegment firstSegment = odataPath.Segments.FirstOrDefault();
116116
if (firstSegment != null)
117117
{
118-
if (firstSegment is EntitySetPathSegment)
118+
var entitySetSegment = firstSegment as EntitySetPathSegment;
119+
if (entitySetSegment != null)
119120
{
120-
controllerName = (firstSegment as EntitySetPathSegment).EntitySetName;
121+
controllerName = entitySetSegment.EntitySetName;
121122
}
122-
else if (firstSegment is SingletonPathSegment)
123+
else
123124
{
124-
controllerName = (firstSegment as SingletonPathSegment).SingletonName;
125+
var singletonSegment = firstSegment as SingletonPathSegment;
126+
if (singletonSegment != null)
127+
{
128+
controllerName = singletonSegment.SingletonName;
129+
}
125130
}
126131
}
127132

0 commit comments

Comments
 (0)