Skip to content

Commit 6cfa591

Browse files
committed
[FIX] base_import_match: Fix tests, name is now required for contacts
1 parent aff3e7c commit 6cfa591

File tree

3 files changed

+12
-18
lines changed

3 files changed

+12
-18
lines changed

base_import_match/models/base.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ def load(self, fields, data):
3434
# Mock Odoo to believe the user is importing the ID field
3535
if "id" not in fields:
3636
fields.append("id")
37-
# Needed to match with converted data field names
3837
for dbid, xmlid, record, info in converted_data:
3938
# In case of one2many on empty lines one record may contain several rows
4039
for row_index in range(info["rows"]["from"], info["rows"]["to"] + 1):
Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
email,function,child_ids/name,child_ids/color,child_ids/email
2-
floyd.steward34@example.com,Bug Fixer,Bart Steward,666,[email protected]
3-
,,Lisa Steward,777,[email protected]
4-
,,Maggie Steward,555,[email protected]
1+
name,email,child_ids/name,child_ids/email
2+
Steward and Co.,stewardcompany@example.com,Bart Steward,[email protected]
3+
,,Lisa Steward,[email protected]
4+
,,Maggie Steward,[email protected]

base_import_match/tests/test_import.py

Lines changed: 8 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -115,40 +115,35 @@ def test_res_users_login(self):
115115
def test_res_partner_email_one2many(self):
116116
"""Change function based on email and import one2many record."""
117117
record = self._base_import_record("res.partner", "res_partner_email_one2many")
118-
record.do(
118+
record.execute_import(
119119
[
120+
"name",
120121
"email",
121-
"function",
122122
"child_ids/name",
123-
"child_ids/color",
124123
"child_ids/email",
125124
],
126125
[],
127126
OPTIONS,
128127
)
129-
self.assertEqual(
130-
self.env.ref("base.res_partner_address_4").function, "Bug Fixer"
128+
parent_partner = self.env["res.partner"].search(
129+
[("name", "=", "Steward and Co.")]
131130
)
132131
self.assertTrue(
133-
self.env.ref("base.res_partner_address_4").child_ids,
132+
parent_partner.child_ids,
134133
)
135134
self.assertEqual(
136-
len(self.env.ref("base.res_partner_address_4").child_ids),
135+
len(parent_partner.child_ids),
137136
3,
138137
)
139138
self.assertEqual(
140-
set(self.env.ref("base.res_partner_address_4").mapped("child_ids.name")),
139+
set(parent_partner.mapped("child_ids.name")),
141140
{"Bart Steward", "Lisa Steward", "Maggie Steward"},
142141
)
143142
self.assertEqual(
144-
set(self.env.ref("base.res_partner_address_4").mapped("child_ids.email")),
143+
set(parent_partner.mapped("child_ids.email")),
145144
{
146145
147146
148147
149148
},
150149
)
151-
self.assertEqual(
152-
set(self.env.ref("base.res_partner_address_4").mapped("child_ids.color")),
153-
{666, 777, 555},
154-
)

0 commit comments

Comments
 (0)