1.0.17

- The config screen now works in 1.21.10
- Added the option to keep Java Edition toast sounds
- Changed the mod id to `console_advancement_sounds`

Author: Jab125

gradle.properties

@@ -9,7 +9,7 @@ loader_version=0.16.14
 loom_version=1.11-SNAPSHOT
 
 # Mod Properties
-mod_version=1.0.16
+mod_version=1.0.17
 maven_group=standard.mod.standard
 archives_base_name=jimmy-smiths
 

src/main/java/standard/mod/standard/DutchWindmills.java

@@ -15,7 +15,7 @@
 import java.util.Map;
 
 public class DutchWindmills implements ModInitializer {
-	public static final String MOD_ID = "jimmy-smiths";
+	public static final String MOD_ID = "console_advancement_sounds";
 
 	// This logger is used to write text to the console and the log file.
 	// It is considered best practice to use your mod id as the logger's name.
@@ -31,9 +31,9 @@ public void onInitialize() {
 		// However, some things (like resources) may still be uninitialized.
 		// Proceed with mild caution.
 		for (Type value : Type.values()) {
-			T.put(value, Registry.register(BuiltInRegistries.SOUND_EVENT, ResourceLocation.parse("jimmy-smiths:advancement-sound." + value.getSerializedName()), SoundEvent.createVariableRangeEvent(ResourceLocation.parse("jimmy-smiths:advancement-sound." + value.getSerializedName()))));
+			T.put(value, Registry.register(BuiltInRegistries.SOUND_EVENT, ResourceLocation.parse("console_advancement_sounds:advancement-sound." + value.getSerializedName()), SoundEvent.createVariableRangeEvent(ResourceLocation.parse("console_advancement_sounds:advancement-sound." + value.getSerializedName()))));
 
-			T2.put(value, Registry.register(BuiltInRegistries.SOUND_EVENT, ResourceLocation.parse("jimmy-smiths:advancement-sound-rare." + value.getSerializedName()), SoundEvent.createVariableRangeEvent(ResourceLocation.parse("jimmy-smiths:advancement-sound-rare." + value.getSerializedName()))));
+			T2.put(value, Registry.register(BuiltInRegistries.SOUND_EVENT, ResourceLocation.parse("console_advancement_sounds:advancement-sound-rare." + value.getSerializedName()), SoundEvent.createVariableRangeEvent(ResourceLocation.parse("console_advancement_sounds:advancement-sound-rare." + value.getSerializedName()))));
 		}
 		LOGGER.info("Hello NeoForge world!");
 		try {

src/main/java/standard/mod/standard/ModConfig.java

@@ -14,7 +14,7 @@
 import java.nio.file.Path;
 
 public class ModConfig {
-	public Type type = Type.PLAYSTATION_4;
+	public Type type = Type.JAVA;
 	public static final Codec<ModConfig> CODEC = RecordCodecBuilder.create(instance -> instance.group(
 			Type.CODEC.fieldOf("sound_platform").forGetter(a -> a.type)
 	).apply(instance, f -> {

src/main/java/standard/mod/standard/Type.java

@@ -6,6 +6,7 @@
 import java.util.Locale;
 
 public enum Type implements StringRepresentable {
+	JAVA("Java Edition", "Java Edition"),
 	XBOX_360("Xbox 360", "X-box 360"),
 	PLAYSTATION_5("Playstation 5", "Paystation 5"),
 	XBOX_ONE("Xbox One", "Xbox 1"),

src/main/java/standard/mod/standard/mixin/ToastManagerMixin.java

@@ -10,14 +10,17 @@
 import org.spongepowered.asm.mixin.Mixin;
 import org.spongepowered.asm.mixin.injection.At;
 import standard.mod.standard.DutchWindmills;
+import standard.mod.standard.Type;
 
 @Mixin(ToastManager.class)
 public class ToastManagerMixin {
 	@WrapOperation(method =
 			"method_61992(Lnet/minecraft/client/gui/components/toasts/Toast;)Z"
 			,at = @At(value = "INVOKE", target = "Lnet/minecraft/client/gui/components/toasts/Toast;getSoundEvent()Lnet/minecraft/sounds/SoundEvent;"))
 	SoundEvent update(Toast instance, Operation<SoundEvent> original) {
+		theIfStatement:
 		if (instance instanceof AdvancementToast toast) {
+			if (DutchWindmills.config.type == Type.JAVA) break theIfStatement;
 			return (toast.getSoundEvent() != null ? DutchWindmills.T2 : DutchWindmills.T).get(DutchWindmills.config.type);
 		}
 		return original.call(instance);

src/main/java/standard/mod/standard/screen/ConfigScreen.java

@@ -26,13 +26,7 @@ public ConfigScreen(Screen parent) {
 	protected void init() {
 		super.init();
 		boolean s;
-		if ( Minecraft.getInstance().getGameProfile() != null) {
-			String name1 = Minecraft.getInstance().getGameProfile().getName();
-			s = name1 != null && (name1.toLowerCase(Locale.ROOT).equals("nicgamertv") || name1.toLowerCase(Locale.ROOT).equals("jab125"));
-		} else {
-			s = false;
-		}
-		s = s? Math.random() < 0.003 : Math.random() < 0.08;
+		s = Math.random() < 0.01;
 		boolean finalS = s;
 		CycleButton.Builder<Type> type = new CycleButton.Builder<>(a -> Component.literal(finalS ? a.d2 : a.d));
 		type.withValues(Type.values());

…n/resources/assets/jimmy-smiths/icon.png …sets/console_advancement_sounds/icon.pngsrc/main/resources/assets/jimmy-smiths/icon.png renamed to src/main/resources/assets/console_advancement_sounds/icon.png src/main/resources/assets/jimmy-smiths/icon.png renamed to src/main/resources/assets/console_advancement_sounds/icon.png

@@ -1,52 +1,52 @@
 {
   "advancement-sound.xbox_360": {
     "sounds": [
-      "jimmy-smiths:advancement-sound-x360"
+      "console_advancement_sounds:advancement-sound-x360"
     ]
   },
   "advancement-sound-rare.xbox_360": {
     "sounds": [
-      "jimmy-smiths:advancement-sound-x360"
+      "console_advancement_sounds:advancement-sound-x360"
     ]
   },
   "advancement-sound.xbox_one": {
     "sounds": [
-      "jimmy-smiths:advancement-sound-x1"
+      "console_advancement_sounds:advancement-sound-x1"
     ]
   },
   "advancement-sound-rare.xbox_one": {
     "sounds": [
-      "jimmy-smiths:advancement-sound-x1-rare"
+      "console_advancement_sounds:advancement-sound-x1-rare"
     ]
   },
   "advancement-sound.playstation_4": {
     "sounds": [
-      "jimmy-smiths:advancement-sound-ps4"
+      "console_advancement_sounds:advancement-sound-ps4"
     ]
   },
   "advancement-sound-rare.playstation_4": {
     "sounds": [
-      "jimmy-smiths:advancement-sound-ps4"
+      "console_advancement_sounds:advancement-sound-ps4"
     ]
   },
   "advancement-sound.playstation_5": {
     "sounds": [
-      "jimmy-smiths:advancement-sound-ps5"
+      "console_advancement_sounds:advancement-sound-ps5"
     ]
   },
   "advancement-sound-rare.playstation_5": {
     "sounds": [
-      "jimmy-smiths:advancement-sound-ps5-rare"
+      "console_advancement_sounds:advancement-sound-ps5-rare"
     ]
   },
   "advancement-sound.steam": {
     "sounds": [
-      "jimmy-smiths:advancement-sound-steam"
+      "console_advancement_sounds:advancement-sound-steam"
     ]
   },
   "advancement-sound-rare.steam": {
     "sounds": [
-      "jimmy-smiths:advancement-sound-steam"
+      "console_advancement_sounds:advancement-sound-steam-rare"
     ]
   }
 }