Skip to content

Commit 6cd3deb

Browse files
bendichterclaude
andcommitted
Fix DynamicTableRegion tests for latest HDMF
HDMF now validates DynamicTableRegion data bounds at construction time, raising IndexError for out-of-range values. Construct without table first, then set table afterwards to bypass validation and test our check function. Fixes #695 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 56c728c commit 6cd3deb

1 file changed

Lines changed: 6 additions & 2 deletions

File tree

tests/unit_tests/test_tables.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,9 @@ def setUp(self):
3232
self.table.add_row(test_column=1)
3333

3434
def test_check_dynamic_table_region_data_validity_lt_zero(self):
35-
dynamic_table_region = DynamicTableRegion(name="dyn_tab", description="desc", data=[-1, 0], table=self.table)
35+
# Create without table to bypass HDMF's validation of data bounds, then set table
36+
dynamic_table_region = DynamicTableRegion(name="dyn_tab", description="desc", data=[-1, 0])
37+
dynamic_table_region.table = self.table
3638

3739
assert check_dynamic_table_region_data_validity(dynamic_table_region) == InspectorMessage(
3840
message="Some elements of dyn_tab are out of range because they are less than 0.",
@@ -44,7 +46,9 @@ def test_check_dynamic_table_region_data_validity_lt_zero(self):
4446
)
4547

4648
def test_check_dynamic_table_region_data_validity_gt_len(self):
47-
dynamic_table_region = DynamicTableRegion(name="dyn_tab", description="desc", data=[0, 20], table=self.table)
49+
# Create without table to bypass HDMF's validation of data bounds, then set table
50+
dynamic_table_region = DynamicTableRegion(name="dyn_tab", description="desc", data=[0, 20])
51+
dynamic_table_region.table = self.table
4852

4953
assert check_dynamic_table_region_data_validity(dynamic_table_region) == InspectorMessage(
5054
message=(

0 commit comments

Comments
 (0)