-
Notifications
You must be signed in to change notification settings - Fork 616
[JAX] Use "nyu-mll/glue" instead of "glue" for encoder datasets to fix 404 error #2625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JAX] Use "nyu-mll/glue" instead of "glue" for encoder datasets to fix 404 error #2625
Conversation
Greptile OverviewGreptile SummaryThis PR updates HuggingFace dataset paths to use the new organization-prefixed format (
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Test as Test Script
participant HF as HuggingFace Datasets API
participant Dataset as Dataset Repository
Note over Test,Dataset: Before: Using deprecated paths
Test->>HF: load_dataset("glue", "cola")
HF->>Dataset: Request from old path
Dataset-->>HF: 404 Not Found
HF-->>Test: Error
Note over Test,Dataset: After: Using new organization paths
Test->>HF: load_dataset("nyu-mll/glue", "cola")
HF->>Dataset: Request from nyu-mll/glue
Dataset-->>HF: Return dataset
HF-->>Test: Dataset loaded
Test->>HF: load_dataset("ylecun/mnist")
HF->>Dataset: Request from ylecun/mnist
Dataset-->>HF: Return dataset
HF-->>Test: Dataset loaded
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No files reviewed, no comments
…error Signed-off-by: Jeremy Berchtold <[email protected]>
bc3729d to
4c8eb15
Compare
|
/te-ci L0 jax |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No files reviewed, no comments
timmoon10
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Jeremy Berchtold <[email protected]>
|
/te-ci L0 jax |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No files reviewed, no comments
Signed-off-by: Jeremy Berchtold <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, 1 comment
| @@ -0,0 +1,3 @@ | |||
| # Datasets used by TE encoder tests. Pull these to pre-emptively cache datasets | |||
| ylecun/mnist | |||
| nyu-mll/glue No newline at end of file | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing newline at end of file
| nyu-mll/glue | |
| nyu-mll/glue | |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
|
/te-ci L0 jax |
KshitijLakhani
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Thanks Jeremy
…x 404 error (#2625) * Use "nyu-mll/glue" instead of "glue" for encoder datasets to fix 404 error Signed-off-by: Jeremy Berchtold <[email protected]> * rename mnist dataset path Signed-off-by: Jeremy Berchtold <[email protected]> * add dataset manifest Signed-off-by: Jeremy Berchtold <[email protected]> --------- Signed-off-by: Jeremy Berchtold <[email protected]>
Description
HF "glue" dataset seems to have moved from "glue" to "nyu-mll/glue". Small PR to update this dataset path as we've started to see 404 errors
Type of change
Changes
Checklist: