♻️ Revert optimistic UI update for NEW mark clearing

♻️ Revert optimistic UI update for NEW mark clearing

Author: WMC001

frontend/app/[locale]/agents/components/AgentManageComp.tsx

@@ -159,7 +159,7 @@ export default function AgentManageComp() {
     }
 
     // Clear NEW mark when agent is selected for editing (only if marked as new)
-    if (agent.is_new) {
+    if (agent.is_new === true) {
       try {
         const res = await clearAgentAndSync(agent.id, queryClient);
         if (!res?.success) {

frontend/app/[locale]/agents/components/agentManage/AgentList.tsx

@@ -42,37 +42,26 @@ export default function AgentList({
   const confirm = useConfirmModal();
   const queryClient = useQueryClient();
 
-  // Local selected agent ID for optimistic UI update (immediate visual feedback)
-  const [locallySelectedAgentId, setLocallySelectedAgentId] = useState<string | null>(null);
-
-  // Track cleared NEW marks to avoid redundant API calls and enable optimistic UI update
-  const clearedNewMarkIds = React.useRef<Set<string>>(new Set());
-
-  // Handle agent selection and clear NEW mark if needed
-  const handleAgentSelect = async (agent: Agent) => {
-    // Optimistic update: immediately set selected state for UI
-    setLocallySelectedAgentId(String(agent.id));
-
-    // Optimistic update: immediately mark as cleared for NEW label
-    if (agent.is_new === true) {
-      clearedNewMarkIds.current.add(String(agent.id));
-    }
-
-    // Only clear NEW mark if agent is marked as new and hasn't been cleared yet
-    if (agent.is_new === true && !clearedNewMarkIds.current.has(String(agent.id))) {
-      try {
-        const res = await clearAgentAndSync(String(agent.id), queryClient);
-        if (res?.success) {
-          clearedNewMarkIds.current.add(String(agent.id));
-        } else {
-          log.warn("Failed to clear NEW mark for agent:", agent.id, res);
-        }
-      } catch (err) {
-        log.error("Error clearing NEW mark:", err);
+  // Note: rely on agent.is_new from agentList (single source of truth).
+  // Clear NEW mark when agent is selected (sync with selection visual feedback)
+  useEffect(() => {
+    if (currentAgentId) {
+      const agentId = String(currentAgentId);
+      const agent = agentList.find(a => String(a.id) === agentId);
+      if (agent?.is_new === true) {
+        (async () => {
+          try {
+            const res = await clearAgentAndSync(agentId, queryClient);
+            if (!res?.success) {
+              log.warn("Failed to clear NEW mark for agent:", agentId, res);
+            }
+          } catch (err) {
+            log.error("Error clearing NEW mark:", err);
+          }
+        })();
       }
     }
-    onSelectAgent(agent);
-  };
+  }, [currentAgentId, agentList]);
 
   // Call relationship modal state
   const [callRelationshipModalVisible, setCallRelationshipModalVisible] =
@@ -303,9 +292,8 @@ export default function AgentList({
                   ? "opacity-60 cursor-not-allowed"
                   : "hover:bg-gray-50 cursor-pointer"
               } ${
-                // Use local state for immediate visual feedback
-                locallySelectedAgentId !== null &&
-                String(locallySelectedAgentId) === String(agent.id)
+                currentAgentId !== null &&
+                String(currentAgentId) === String(agent.id)
                   ? "bg-blue-50 selected-row pl-3"
                   : ""
               }`;
@@ -314,7 +302,7 @@ export default function AgentList({
               onClick: (e: any) => {
                 e.preventDefault();
                 e.stopPropagation();
-                handleAgentSelect(agent);
+                onSelectAgent(agent);
               },
             })}
             columns={[
@@ -324,12 +312,10 @@ export default function AgentList({
                   const isAvailable = agent.is_available !== false;
                   const displayName = agent.display_name || "";
                   const name = agent.name || "";
-                  // Use local state for immediate visual feedback
                   const isSelected =
-                    locallySelectedAgentId !== null &&
-                    String(locallySelectedAgentId) === String(agent.id);
-                  // Optimistic update: use clearedNewMarkIds to hide NEW immediately after click
-                  const isNew = (agent.is_new || false) && !clearedNewMarkIds.current.has(String(agent.id));
+                    currentAgentId !== null &&
+                    String(currentAgentId) === String(agent.id);
+                  const isNew = agent.is_new || false;
 
                   return (
                     <Flex