pr comments

Author: Alessandro100

web-app/src/app/screens/Feeds/utility.spec.ts

@@ -115,7 +115,13 @@ describe('utility.ts', () => {
 
     test('filters to allowed values', () => {
       expect(
-        parseQueryParamStatus(['active', 'deprecated', 'inactive', 'future']),
+        parseQueryParamStatus([
+          'active',
+          'deprecated',
+          'inactive',
+          'future',
+          'development',
+        ]),
       ).toEqual(['active', 'inactive', 'future']);
     });
 

web-app/src/app/screens/Feeds/utility.ts

@@ -1,4 +1,5 @@
-export type AllowedFeedSearchStatus = 'active' | 'inactive' | 'future';
+const ALLOWED_FEED_STATUSES = ['active', 'inactive', 'future'] as const;
+export type AllowedFeedSearchStatus = (typeof ALLOWED_FEED_STATUSES)[number];
 
 export function getDataTypeParamFromSelectedFeedTypes(
   selectedFeedTypes: Record<string, boolean>,
@@ -48,6 +49,6 @@ export const parseQueryParamStatus = (
   queryStatus: string[] | undefined,
 ): AllowedFeedSearchStatus[] => {
   return (queryStatus?.filter((s) =>
-    ['active', 'inactive', 'future'].includes(s),
+    ALLOWED_FEED_STATUSES.includes(s as AllowedFeedSearchStatus),
   ) ?? []) as AllowedFeedSearchStatus[];
 };