Directly pass the packet buffer to the queue when it is direct (#23)

MinnDevelopment · web-flow · commit 96e5a596abc7 · 2025-12-30T16:24:37.000+01:00
* Directly pass the packet buffer to the queue when it is direct

* Bump version to 0.2.12
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## v0.2.11 - 2025/12/30
+
+- Avoid copying buffers when they are already direct
+
 ## v0.2.11 - 2025/12/23
 
 - Add support for windows aarch64
diff --git a/README.md b/README.md
@@ -49,8 +49,8 @@ repositories {
 
 dependencies {
     // Fully modular, choose which platforms to use!
-    implementation("club.minnced:udpqueue-native-linux-x86-64:0.2.11") // adds linux 64bit
-    implementation("club.minnced:udpqueue-native-win-x86-64:0.2.11") // adds windows 64bit
+    implementation("club.minnced:udpqueue-native-linux-x86-64:0.2.12") // adds linux 64bit
+    implementation("club.minnced:udpqueue-native-win-x86-64:0.2.12") // adds windows 64bit
 }
 ```
 
@@ -71,15 +71,15 @@ repositories {
 }
 
 dependencies {
-    implementation("club.minnced:udpqueue-native-linux-x86-64:0.2.11")
-    implementation("club.minnced:udpqueue-native-linux-x86:0.2.11")
-    implementation("club.minnced:udpqueue-native-linux-aarch64:0.2.11")
-    implementation("club.minnced:udpqueue-native-linux-arm:0.2.11")
-    implementation("club.minnced:udpqueue-native-linux-musl-x86-64:0.2.11")
-    implementation("club.minnced:udpqueue-native-linux-musl-aarch64:0.2.11")
-    implementation("club.minnced:udpqueue-native-win-x86-64:0.2.11")
-    implementation("club.minnced:udpqueue-native-win-x86:0.2.11")
-    implementation("club.minnced:udpqueue-native-win-aarch64:0.2.11")
-    implementation("club.minnced:udpqueue-native-darwin:0.2.11")
+    implementation("club.minnced:udpqueue-native-linux-x86-64:0.2.12")
+    implementation("club.minnced:udpqueue-native-linux-x86:0.2.12")
+    implementation("club.minnced:udpqueue-native-linux-aarch64:0.2.12")
+    implementation("club.minnced:udpqueue-native-linux-arm:0.2.12")
+    implementation("club.minnced:udpqueue-native-linux-musl-x86-64:0.2.12")
+    implementation("club.minnced:udpqueue-native-linux-musl-aarch64:0.2.12")
+    implementation("club.minnced:udpqueue-native-win-x86-64:0.2.12")
+    implementation("club.minnced:udpqueue-native-win-x86:0.2.12")
+    implementation("club.minnced:udpqueue-native-win-aarch64:0.2.12")
+    implementation("club.minnced:udpqueue-native-darwin:0.2.12")
 }
 ```
diff --git a/api/src/main/java/com/sedmelluq/discord/lavaplayer/udpqueue/natives/UdpQueueManager.java b/api/src/main/java/com/sedmelluq/discord/lavaplayer/udpqueue/natives/UdpQueueManager.java
@@ -66,12 +66,18 @@ public boolean queuePacket(long key, ByteBuffer packet, InetSocketAddress addres
       }
 
       int length = packet.remaining();
-      packetBuffer.clear();
-      packetBuffer.put(packet);
+      ByteBuffer directBuffer;
+      if (packet.isDirect()) {
+          directBuffer = packet;
+      } else {
+          packetBuffer.clear();
+          packetBuffer.put(packet);
+          directBuffer = packetBuffer;
+      }
 
       int port = address.getPort();
       String hostAddress = address.getAddress().getHostAddress();
-      return library.queuePacket(instance, key, hostAddress, port, packetBuffer, length);
+      return library.queuePacket(instance, key, hostAddress, port, directBuffer, length);
     }
   }
 
diff --git a/build.gradle.kts b/build.gradle.kts
@@ -16,5 +16,5 @@ subprojects {
     }
 
     group = "club.minnced"
-    version = "0.2.11"
+    version = "0.2.12"
 }
diff --git a/native/Cargo.lock b/native/Cargo.lock
diff --git a/native/Cargo.toml b/native/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "udpqueue"
-version = "0.2.11"
+version = "0.2.12"
 edition = "2024"
 
 [dependencies]

Original file line number	Diff line number	Diff line change
`@@ -66,12 +66,18 @@ public boolean queuePacket(long key, ByteBuffer packet, InetSocketAddress addres`
`66`	`66`	`}`
`67`	`67`
`68`	`68`	`int length = packet.remaining();`
`69`		`- packetBuffer.clear();`
`70`		`- packetBuffer.put(packet);`
	`69`	`+ ByteBuffer directBuffer;`
	`70`	`+ if (packet.isDirect()) {`
	`71`	`+ directBuffer = packet;`
	`72`	`+ } else {`
	`73`	`+ packetBuffer.clear();`
	`74`	`+ packetBuffer.put(packet);`
	`75`	`+ directBuffer = packetBuffer;`
	`76`	`+ }`
`71`	`77`
`72`	`78`	`int port = address.getPort();`
`73`	`79`	`String hostAddress = address.getAddress().getHostAddress();`
`74`		`- return library.queuePacket(instance, key, hostAddress, port, packetBuffer, length);`
	`80`	`+ return library.queuePacket(instance, key, hostAddress, port, directBuffer, length);`
`75`	`81`	`}`
`76`	`82`	`}`
`77`	`83`
Original file line number	Diff line number	Diff line change
`@@ -16,5 +16,5 @@ subprojects {`
`16`	`16`	`}`
`17`	`17`
`18`	`18`	`group = "club.minnced"`
`19`		`- version = "0.2.11"`
	`19`	`+ version = "0.2.12"`
`20`	`20`	`}`