Badge no longer displays after Turbo Drive page load w/ Turbo 8 (even w/ enable_hotwire_turbo_drive_support = true)

[charlesobrien]

Issue: After upgrading to Turbo 8 the Rack Mini Profiler badge no longer displays after a Turbo Drive action with Rack::MiniProfiler.config.enable_hotwire_turbo_drive_support = true. If I revert back to Turbo 7 / Turbo Rails 1.5 the behavior works as expected.

Expected Behavior: When a page loads with Turbo Drive the Rack Mini Profiler badge displays.

Actual Behavior: When a page loads with Turbo Drive the Rack Mini Profiler badge does not display.

[joshuay03]

I dug into this a bit cause it's affecting our app as well.

From what I can tell, Turbo 8 references and uses the native window.fetch function for its requests (added in hotwired/turbo#1019). As a result, this override is never utilised by Turbo Drive because the Turbo scripts are preloaded before the profiler script is executed:

[charlesobrien]

@joshuay03 Thanks for sharing! My spelunking was leaving me stumped.

[PabloScolpino]

Apologies if this is self-evident and I'm not seeing the solution.

What is the intended fix for this? If any.
OR, do you ppl have a suggested workaround?

Thanks

[joshuay03]

What is the intended fix for this? If any. OR, do you ppl have a suggested workaround?

I think we can try removing the async from the mini-profiler script? My understanding is that it should be executed first cause it's blocking. Could you give that a go?

Edit: Tried this, didn't work. Hopefully someone who's more JS savvy can chime in.

[pinzonjulian]

I've ran into this too in both a Rails 7 a Rails 8 app. Both are using recent versions of Turbo: 8.0.5 and 8.0.10

rack-mini-profiler-test-case.mov

You can try it out here:
https://github.com/pinzonjulian/mini-profiler-turbo-test

[coalest]

@pinzonjulian Thanks for the testing app. It helped debug this issue.

I think #631 should resolve this issue 🙏

[webzorg]

@pinzonjulian Thanks for the testing app. It helped debug this issue.

I think #631 should resolve this issue 🙏

I can confirm this solves the issue!