Add missing C2554 f1_keywords and helpviewer_keywords in "Compiler errors C2500 Through C2599"
#5673
Conversation
…r errors C2500 Through C2599"
|
@Rageking8 : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
|
Learn Build status updates of commit 72e3d0c: ✅ Validation status: passed
For more details, please refer to the build report. |
| f1_keywords: ["C2501", "C2508", "C2515", "C2519", "C2520", "C2522", "C2525", "C2527", "C2536", "C2538", "C2539", "C2546", "C2547", "C2554", "C2559", "C2560", "C2564", "C2565", "C2576", "C2578", "C2580", "C2590", "C2591", "C2595", "C2596"] | ||
| helpviewer_keywords: ["C2501", "C2508", "C2515", "C2519", "C2520", "C2522", "C2525", "C2527", "C2536", "C2538", "C2539", "C2546", "C2547", "C2554", "C2559", "C2560", "C2564", "C2565", "C2576", "C2578", "C2580", "C2590", "C2591", "C2595", "C2596"] | ||
| --- | ||
| # Compiler errors C2500 Through C2599 |
There was a problem hiding this comment.
Just realized that the "Through" here should not be capitalized. There seem to be quite a few matches, but I will fix this in a future PR.
There was a problem hiding this comment.
I fixed it while I'm here (thanks for pointing it out). Shouldn't cause a merge conflict if there's a downstream fix for this since it'll be the same change.
|
Can you review the proposed changes? Important: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
prmerger-automator
bot
added
the
aq-pr-triaged
TylerMSFT
left a comment
TylerMSFT
left a comment
There was a problem hiding this comment.
And what was lost (to help) now is found.
|
Learn Build status updates of commit 8d8092d: ✅ Validation status: passed
For more details, please refer to the build report. |
|
#sign-off |
There was a problem hiding this comment.
Pull request overview
This pull request addresses a metadata inconsistency by adding the missing C2554 error code to the f1_keywords and helpviewer_keywords lists. The PR description notes that C2554 was added to the document body in a previous commit but the metadata fields were not updated at that time. Additionally, the description field is updated to use lowercase "through" instead of capitalized "Through".
Changes:
- Added "C2554" to both
f1_keywordsandhelpviewer_keywordsmetadata arrays - Changed capitalization in the description field from "Through" to "through"
| --- | ||
| title: "Compiler errors C2500 Through C2599" | ||
| description: "Learn more about: Compiler errors C2500 Through C2599" | ||
| description: "Learn more about: Compiler errors C2500 through C2599" |
There was a problem hiding this comment.
The title uses "Through" (capitalized) while the description now uses "through" (lowercase). While newer files in this repository use lowercase "through" consistently in both fields (e.g., compiler-errors-c3500-through-c3999.md, compiler-errors-c7000-through-c7499.md), this change creates an inconsistency within this file. Consider updating the title field on line 2 to also use lowercase "through" to match the description field and align with the newer convention seen in similar files.
5 participants
C2554 was added in commit 6ec0265, but the
f1_keywordsandhelpviewer_keywordswere not updated. No other errors seem to be missing or extraneous.