Conversation
… for AccountProvider
Contributor
Author
|
@metamaskbot publish-previews |
a7b9cca to
cdbb1f2
Compare
createAccounts options for AccountProvider
danroc
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Start using new keyring v2 idioms for the
AccountProvider.Note
Medium Risk
This is a breaking public API type change; downstream providers/consumers must update implementations and call sites, but there is minimal runtime logic change beyond interface conformance.
Overview
Updates the
AccountProviderAPI to align with keyring v2 by adding a requiredcapabilities: KeyringCapabilitiesgetter and changingcreateAccountsto acceptCreateAccountOptionsinstead of{ entropySource, groupIndex }.Documents the change as BREAKING in the
account-apichangelog, noting the new options enable additional account construction modes (e.g., multiple indexes at once).Written by Cursor Bugbot for commit 9c04aa1. This will update automatically on new commits. Configure here.