Skip to content

feat(account-api)!: use keyring capabilities + createAccounts options for AccountProvider#462

Merged
ccharly merged 5 commits intomainfrom
cc/feat/account-provider-createAccounts
Feb 6, 2026
Merged

feat(account-api)!: use keyring capabilities + createAccounts options for AccountProvider#462
ccharly merged 5 commits intomainfrom
cc/feat/account-provider-createAccounts

Conversation

@ccharly
Copy link
Contributor

@ccharly ccharly commented Feb 6, 2026

Start using new keyring v2 idioms for the AccountProvider.


Note

Medium Risk
This is a breaking public API type change; downstream providers/consumers must update implementations and call sites, but there is minimal runtime logic change beyond interface conformance.

Overview
Updates the AccountProvider API to align with keyring v2 by adding a required capabilities: KeyringCapabilities getter and changing createAccounts to accept CreateAccountOptions instead of { entropySource, groupIndex }.

Documents the change as BREAKING in the account-api changelog, noting the new options enable additional account construction modes (e.g., multiple indexes at once).

Written by Cursor Bugbot for commit 9c04aa1. This will update automatically on new commits. Configure here.

@ccharly ccharly requested a review from a team as a code owner February 6, 2026 09:10
@ccharly
Copy link
Contributor Author

ccharly commented Feb 6, 2026

@metamaskbot publish-previews

@ccharly ccharly force-pushed the cc/feat/account-provider-createAccounts branch from a7b9cca to cdbb1f2 Compare February 6, 2026 09:53
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

@ccharly ccharly changed the title feat(account-api)!: use keyring capabilities + createAccounts options for AccountProvider feat(account-api)!: use keyring capabilities + createAccounts options for AccountProvider Feb 6, 2026
@ccharly ccharly enabled auto-merge February 6, 2026 10:53
@ccharly ccharly added this pull request to the merge queue Feb 6, 2026
Merged via the queue into main with commit bd1a79c Feb 6, 2026
38 checks passed
@ccharly ccharly deleted the cc/feat/account-provider-createAccounts branch February 6, 2026 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants