feat: add optional createAccounts method based on KeyringV2#448
Merged
feat: add optional createAccounts method based on KeyringV2#448
createAccounts method based on KeyringV2#448Conversation
a1cd60d to
3840f34
Compare
danroc
reviewed
Feb 4, 2026
danroc
reviewed
Feb 4, 2026
danroc
reviewed
Feb 4, 2026
danroc
reviewed
Feb 5, 2026
danroc
reviewed
Feb 5, 2026
Contributor
Author
|
@metamaskbot publish-preview |
danroc
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a new optional
createAccountsmethod that we could already leverage today without having the full implementation ofKeyringV2.Note
Medium Risk
Touches core account-creation pathways and introduces batch mutation with rollback and locking, which could affect state consistency and Snap interactions if edge cases are missed.
Overview
Introduces an optional
Keyring.createAccountsmethod plus a newkeyring_createAccountsRPC (KeyringRpcMethod.CreateAccounts) that accepts typed v2CreateAccountOptionsand returns an array of accounts.Wires the new RPC end-to-end:
keyring-snap-sdkdispatcheskeyring_createAccounts(and errors when unimplemented),keyring-snap-clientaddsKeyringClient.createAccounts, andSnapKeyringimplements batch creation by validating/adding returned accounts to internal state (without per-accountnotify:accountCreated), enforcing idempotency, rejecting duplicates/unsupported generic accounts, rolling back Snap state viadeleteAccounton failure, and serializing concurrent calls via anasync-mutexlock.Written by Cursor Bugbot for commit 7ec3108. This will update automatically on new commits. Configure here.