chore: Run the fabric example on gesture-handler v3 - #582
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
github-actions
Bot
added
chore
dependencies
MatiPl01
force-pushed
the
chore/gesture-handler-v3-fabric-example
branch
from
July 4, 2026 08:24
04f3e3e to
e64cd37
Compare
The fabric example targets the New Architecture, so run it on gesture-handler v3 (which drops Old Architecture support) while the paper example stays on v2. Two shared-script changes let the examples use different majors of a dependency: - getDependencies resolves each dependency with require.resolve instead of a hardcoded node_modules path, so it is hoist-proof: an app pinning a divergent major autolinks that version wherever yarn placed it. - createMetroConfig gains a filterFromCommonApp option that blocks the shared example app's copy of a module, so a host bundling on a different major resolves its own version, matching the native build. The fabric example then only declares gesture-handler v3 and passes it to filterFromCommonApp.
MatiPl01
force-pushed
the
chore/gesture-handler-v3-fabric-example
branch
from
July 4, 2026 10:35
e64cd37 to
bee9e1f
Compare
Owner
Author
|
馃帀 This PR is included in version 1.10.0 馃帀 The release is available on: Your semantic-release bot 馃摝馃殌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #573.
The fabric example targets the New Architecture, so this points it at gesture-handler v3 (which drops Old Architecture support) while the paper example stays on v2. It gives the repo a working v3 example on the New Architecture.
Because the two examples now use different gesture-handler majors, two resolution fixes are needed, both scoped to the fabric example:
react-native.config.jsresolves gesture-handler from the fabric app's own dependency (hoisted to the monorepo root). The sharedgetDependenciesresolver points a differing-version dep at a localnode_modulespath that does not exist once v3 is hoisted, which silently drops the native module from autolinking.metro.config.jsblocks the v2 copy nested under the shared example app so the JS bundle resolves the same v3 the native build links against.Verified on an Android emulator (New Architecture): the full example app builds, runs, and reorders via drag-and-drop on gesture-handler v3, and the paper example's v2 resolution is unchanged.