- See the branch bugfix/gamma_diff_overflow
- Please run the test in tests/test_spectral_abscissa_diff.
There are multiple issues here:
-
compressed diff: in the function spectral_abscissa_diff, it compresses the delays. I think this should not be there if we are discussing the closed_loop diff. If we compress the diff, then the size of the normalized_diff is reduced and it does not take into account the uncertainty of the 0-delay term in the closed-loop.
-
tdcpy.spectral_abscissa.spectral_abscissa_diff: gives incorrect result for case 1
-
overflow: Added a logger.debug message at line 363 of gamma_normalized_diff. The problem occurs in line 359, 365.
To-do: remove the line in code and delete test after bug fix.
There are multiple issues here:
compressed diff: in the function spectral_abscissa_diff, it compresses the delays. I think this should not be there if we are discussing the closed_loop diff. If we compress the diff, then the size of the normalized_diff is reduced and it does not take into account the uncertainty of the 0-delay term in the closed-loop.
tdcpy.spectral_abscissa.spectral_abscissa_diff: gives incorrect result for case 1
overflow: Added a logger.debug message at line 363 of gamma_normalized_diff. The problem occurs in line 359, 365.
To-do: remove the line in code and delete test after bug fix.