Skip to content

Commit 349d95e

Browse files
authored
Context Menu, CSS Modules and React 19 (#1015)
This replaces the context menu with our own. By doing that we no longer need to force install our npm packages, as there are no longer any conflicts. In fact, as part of this change, I updated us to the latest React 19 and even enabled the React compiler. I also explored CSS modules for the first time, which are going to allow us to reduce conflicts between CSS rules and possibly even allow us to fully remove SASS, as the need for it is going to be reduced. I also found out that the latest Rust nightly is broken due to their update to LLVM 20. So I pinned the version to the last working nightly version.
1 parent 55162c0 commit 349d95e

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

50 files changed

+1288
-1063
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ jobs:
7070
- name: Install Rust
7171
uses: hecrj/setup-rust-action@v2
7272
with:
73-
rust-version: nightly
73+
rust-version: nightly-2025-02-17
7474
components: rust-src
7575
targets: wasm32-unknown-unknown
7676

@@ -114,7 +114,7 @@ jobs:
114114
mv wasm-bindgen-${{ steps.wasm-bindgen.outputs.version }}-${{ matrix.target }}/wasm* .
115115
116116
- name: Install npm packages
117-
run: npm ci -f
117+
run: npm ci
118118
env:
119119
DETECT_CHROMEDRIVER_VERSION: true
120120

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ cargo install wasm-bindgen-cli
4040
You need to set up some npm modules before compiling the project:
4141

4242
```bash
43-
npm install -f
43+
npm install
4444
```
4545

4646
You are now ready to build livesplit-core, which powers LiveSplit One:

buildCore.js

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,17 @@ if (process.argv.some((v) => v === "--max-opt")) {
2828
if (process.argv.some((v) => v === "--unstable")) {
2929
// Relaxed SIMD is not supported by Firefox and Safari yet.
3030
rustFlags += ",+relaxed-simd";
31+
32+
// Not supported by any browser yet.
33+
rustFlags += ",+wide-arithmetic";
3134
}
3235

3336
// Use the nightly toolchain, which enables some more optimizations.
3437
if (process.argv.some((v) => v === "--nightly")) {
35-
toolchain = "+nightly";
38+
// FIXME: Nightly is broken since the LLVM 20 upgrade. We need to wait for
39+
// stdarch (which has the fix already) to be updated:
40+
// https://github.com/rust-lang/stdarch/pull/1719
41+
toolchain = "+nightly-2025-02-17";
3642
cargoFlags +=
3743
" -Z build-std=std,panic_abort -Z build-std-features=panic_immediate_abort";
3844
rustFlags += " -Z wasm-c-abi=spec";

0 commit comments

Comments
 (0)