Skip to content

[Refactor] replace querySelector with getElementById where possible, cache querySelector calls where posssible and needed #3046

@jxn-30

Description

@jxn-30

DOM-Operations and querySelector are heavy operations. getElementById is much faster than querySelector('#id'), especially if called often (e.g. in loops and intervals).
If multiple operations need to be done on an element, avoid selecting the element multiple times but cache it (store it in a variable or in an object) instead.

ESLint Rule unicorn/prefer-query-selector needs to be explicitely be disabled therefore.

An ESLint Rule enforcing us to prefer getElementById wherever possible would be good!

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions