Skip to content

Commit afeace2

Browse files
authored
Reloading Annotations Fix (#1543)
* layer rendering when tracks don't exist * fix loading original in revision browser * reorder clearing process
1 parent 97726a7 commit afeace2

File tree

4 files changed

+13
-12
lines changed

4 files changed

+13
-12
lines changed

client/dive-common/components/Viewer.vue

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -733,10 +733,10 @@ export default defineComponent({
733733
loadData();
734734
735735
const reloadAnnotations = async () => {
736-
mediaControllerClear();
737-
cameraStore.clearAll();
738-
discardChanges();
739736
progress.loaded = false;
737+
discardChanges();
738+
cameraStore.clearAll();
739+
mediaControllerClear();
740740
await loadData();
741741
displayComparisons.value = props.comparisonSets.length
742742
? props.comparisonSets.slice(0, 1) : props.comparisonSets;

client/platform/web-girder/views/RevisionHistory.vue

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ export default defineComponent({
2626
await loadNextPage((l, o) => loadRevisions(datasetId.value, l, o, undefined, currentSet.value));
2727
}
2828
29-
function checkout(id: number) {
29+
function checkout(id: number | undefined) {
3030
emit('update:revision', id, currentSet.value);
3131
reloadAnnotations();
3232
}
@@ -78,11 +78,7 @@ export default defineComponent({
7878
<v-btn
7979
x-small
8080
depressed
81-
:to="{
82-
name: 'viewer',
83-
params: { id: datasetId },
84-
}
85-
"
81+
@click="checkout(undefined)"
8682
>
8783
Return to newest revision
8884
</v-btn>

client/platform/web-girder/views/ViewerLoader.vue

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -161,12 +161,17 @@ export default defineComponent({
161161
window.removeEventListener('beforeunload', viewerRef.value.warnBrowserExit);
162162
});
163163
164-
function routeRevision(revisionId: number, set?: string) {
165-
if (set && set !== 'default') {
164+
function routeRevision(revisionId: number | undefined, set?: string) {
165+
if (set && set !== 'default' && revisionId !== undefined) {
166166
router.replace({
167167
name: 'revision set viewer',
168168
params: { id: props.id, revision: revisionId.toString(), set },
169169
});
170+
} else if (revisionId === undefined) {
171+
router.replace({
172+
name: 'viewer',
173+
params: { id: props.id },
174+
});
170175
} else {
171176
router.replace({
172177
name: 'revision viewer',

client/src/components/LayerManager.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,7 @@ export default defineComponent({
200200
}
201201
currentFrameIds.forEach(
202202
(trackId: AnnotationId) => {
203-
const track = trackStore?.get(trackId);
203+
const track = trackStore?.getPossible(trackId);
204204
if (track === undefined) {
205205
// Track may be located in another Camera
206206
// TODO: Find a better way to represent tracks outside of cameras

0 commit comments

Comments
 (0)