Skip to content

Commit 8883213

Browse files
authored
Fix test 'Shift-click to select and deselect sketch segments' (#8390)
1 parent cecf020 commit 8883213

File tree

1 file changed

+10
-5
lines changed

1 file changed

+10
-5
lines changed

e2e/playwright/point-click.spec.ts

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -861,8 +861,11 @@ openSketch = startSketchOn(XY)
861861
const firstPointLocation = { x: 200, y: 100 }
862862
const secondPointLocation = { x: 800, y: 100 }
863863
const thirdPointLocation = { x: 800, y: 400 }
864-
const firstSegmentLocation = { x: 750, y: 100 }
865-
const secondSegmentLocation = { x: 800, y: 150 }
864+
// @pierremtb: moved the select location to the arrow at the end after the engine zoom fix
865+
// got in https://github.com/KittyCAD/engine/pull/3804, seemed like it allowed for more
866+
// error margin but unclear why
867+
const firstSegmentLocation = { x: 799, y: 100 }
868+
const secondSegmentLocation = { x: 800, y: 399 }
866869
const planeLocation = { x: 700, y: 200 }
867870

868871
// Click helpers
@@ -892,10 +895,12 @@ openSketch = startSketchOn(XY)
892895
)
893896

894897
// Colors
895-
const edgeColorWhite: [number, number, number] = [220, 220, 220]
896-
const edgeColorBlue: [number, number, number] = [20, 20, 200]
898+
// @pierremtb: had to tone these colors down a bit after the engine zoom fix
899+
// in https://github.com/KittyCAD/engine/pull/3804, unclear why
900+
const edgeColorWhite: [number, number, number] = [150, 150, 150]
901+
const edgeColorBlue: [number, number, number] = [10, 10, 150]
897902
const backgroundColor: [number, number, number] = [30, 30, 30]
898-
const tolerance = 40
903+
const tolerance = 50
899904
const timeout = 150
900905

901906
// Setup

0 commit comments

Comments
 (0)