encode: fixups for encode: remove the CPU

- revert dumpShaders debug flag to false

- fix pushConstantRange size to match shader layout:
Use sizeof(PushConstants) to keep the pipeline layout size in sync
with the C++ struct automatically, as done in nvpro commit c2a2fc0
("common: Optimize shader by precomputing half-resolution in push
constants").

Fixes VUID-vkCmdPushConstants-offset-01795 reported by the Vulkan
Validation Layers when running the encoder with the compute filter
enabled (SHADERC_SUPPORT).

- YcbcrUtils: add assert for unknown bpp in GetBitsPerChannel

Function added in 8f6be61 silently returns 8 for unrecognized bpp
values. Add assert to catch misuse in debug builds.

Author: dabrain34

common/include/nvidia_utils/vulkan/ycbcr_utils.h

@@ -117,6 +117,7 @@ static inline uint32_t GetBitsPerChannel(const YcbcrPlanesLayoutInfo& pYcbcrPlan
         case YCBCRA_16BPP:
             return 16;
         default:
+            assert(!"Unknown bpp value in GetBitsPerChannel");
             return 8;
     }
 }

common/libs/VkCodecUtils/VulkanFilterYuvCompute.cpp

@@ -17,7 +17,7 @@
 #include "VulkanFilterYuvCompute.h"
 #include "nvidia_utils/vulkan/ycbcrvkinfo.h"
 
-static bool dumpShaders = true;
+static bool dumpShaders = false;
 
 VkResult VulkanFilterYuvCompute::Create(const VulkanDeviceContext* vkDevCtx,
                                         uint32_t queueFamilyIndex,
@@ -176,7 +176,7 @@ VkResult VulkanFilterYuvCompute::InitDescriptorSetLayout(uint32_t maxNumFrames)
     VkPushConstantRange pushConstantRange = {};
     pushConstantRange.stageFlags = VK_SHADER_STAGE_COMPUTE_BIT; // Stage the push constant is for
     pushConstantRange.offset = 0;
-    pushConstantRange.size = 6 * sizeof(uint32_t); // Size of the push constant - source and destination image layers + 2 * ivec2
+    pushConstantRange.size = sizeof(PushConstants); // Size of the push constant - source and destination image layers + 2 * ivec2
 
     return m_descriptorSetLayout.CreateDescriptorSet(m_vkDevCtx,
                                                      setLayoutBindings,