[ Interactive Graph | Vector Graph ] PR2: State Management#3434
[ Interactive Graph | Vector Graph ] PR2: State Management#3434SonicScrewdriver wants to merge 6 commits intoLEMS-3971/vector-pr1from
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
🗄️ Schema Change: No Changes ✅ |
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (c6ebc40) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR3434If you are working in Khan Academy's frontend, you can run the below command. ./dev/tools/bump_perseus_version.ts -t PR3434If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -t PR3434 |
🛠️ Item Splitting: No Changes ✅ |
|
Size Change: +115 B (+0.02%) Total Size: 499 kB 📦 View Changed
ℹ️ View Unchanged
|
cd4b7ce to
68ae5c4
Compare
fbb7178 to
705a8e0
Compare
5726e2e to
de186e6
Compare
705a8e0 to
86a5da9
Compare
86a5da9 to
da4b606
Compare
There was a problem hiding this comment.
Wow this file is really getting longer 😢 I almost got confused on the diff 🙈
No action required here for now. I'm just thinking if we want to move the functions to a reducer-utils/doMoveLine.ts and reducer-utiles/* 🤔
de186e6 to
ea67f91
Compare
…ement logic for new Vector graph
c6ebc40 to
ad02a65
Compare
Summary
This PR was created with the help of AI, albeit with heavy oversight and review.
This is part of a series of PRs implementing the vector graph type for the Interactive Graph widget:
PR1 – type definitions and schema
▶️ PR2 – state management (this PR)
PR3 – rendering & accessibility
PR4 – scoring
PR5 – editor support
Issue: LEMS-3971
Changes:
vector: { moveTip, moveVector }to the actions object.moveTipdispatchesmovePoint(1, destination)for the tip (the only draggable point).moveVectordispatchesmoveLine(0, delta)for body translation.case "vector". Adds and exportsgetVectorCoords()with the standard three-path fallback: explicit coords → startCoords → normalized defaults. Default is a horizontal vector from [-5, 0] to [5, 0].doMovePoint(snap to grid, enforce bounds, reject if tip would overlap with tail). Adds"vector"to the existingdoMoveLinecase alongside"linear"/"ray"for body translation.getGradableGraph()branch for vector (coords passthrough, same shape as ray).withVector()builder method andVectorGraphConfigclass (matchesRayGraphConfigpattern).generateIGVectorGraph()generator function (new pattern, replacing builder long-term).generateIGVectorGraph.getVectorCoords.vectorQuestionandvectorQuestionWithDefaultCorrecttest fixtures.Test plan:
pnpm tsc— no new type errorspnpm test packages/perseus/src/widgets/interactive-graphs/reducer/— 143 tests pass, including 9 new vector tests: