restrict (most) new setters to private access

Author: edcallaghan

Fit/DomainWall.hh

@@ -51,15 +51,16 @@ namespace KinKal {
       auto const& prevWeight() const { return prevwt_; }
       auto const& nextWeight() const { return nextwt_; }
       auto const& fwdCovarianceRotation() const { return dpdpdb_; }
-      void setPrevPtr(DOMAINPTR const& ptr){ prev_ = ptr; }
-      void setNextPtr(DOMAINPTR const& ptr){ next_ = ptr; }
 
     private:
       DOMAINPTR prev_, next_; // pointers to previous and next domains
       DVEC dpfwd_; // parameter change across this domain wall in the forwards time direction
       Weights prevwt_, nextwt_; // cache of weights
       PSMAT dpdpdb_; // forward rotation of covariance matrix going in the forwards direction
 
+      // modifiers to support cloning
+      void setPrevPtr(DOMAINPTR const& ptr){ prev_ = ptr; }
+      void setNextPtr(DOMAINPTR const& ptr){ next_ = ptr; }
   };
 
   template<class KTRAJ> DomainWall<KTRAJ>::DomainWall(

Fit/Material.hh

@@ -39,12 +39,13 @@ namespace KinKal {
       auto const& elementXing() const { return *exingptr_; }
       auto const& elementXingPtr() const { return exingptr_; }
       auto const& referenceTrajectory() const { return exingptr_->referenceTrajectory(); }
-      // other accessors
       auto const& weights() const { return nextwt_; }
-      void setElementXingPtr(EXINGPTR const& ptr){ exingptr_ = ptr; }
     private:
       EXINGPTR exingptr_; // element crossing for this effect
       Weights nextwt_; // cache of weight forwards of this effect.
+
+      // modifiers to support cloning
+      void setElementXingPtr(EXINGPTR const& ptr){ exingptr_ = ptr; }
   };
 
   template<class KTRAJ> Material<KTRAJ>::Material(EXINGPTR const& exingptr, PTRAJ const& ptraj) : exingptr_(exingptr) {

Fit/Measurement.hh

@@ -37,10 +37,11 @@ namespace KinKal {
       std::unique_ptr< Effect<KTRAJ> > clone(CloneContext&) const override;
       // access the underlying hit
       HITPTR const& hit() const { return hit_; }
-      // other accessors
-      void setHitPtr(HITPTR const& ptr){ hit_ = ptr; }
     private:
       HITPTR hit_ ; // hit used for this measurement
+
+      // modifiers to support cloning
+      void setHitPtr(HITPTR const& ptr){ hit_ = ptr; }
   };
 
   template<class KTRAJ> Measurement<KTRAJ>::Measurement(HITPTR const& hit,PTRAJ const& ptraj) : hit_(hit) {