Conversation
- Use JavaScript evaluate() to directly check filter checkboxes in webkit since click actions don't change checkbox state even with force:true - Accept both "Notifications Enabled" and "Notifications Blocked" toast messages since webkit doesn't honor context.grantPermissions()
Root cause: The sticky .filter-panel lacked z-index and background, causing webkit's stricter hit-testing to detect visual overlap with the .series-panel below it during scroll. Fix: - Add z-index: 10 and background: white to .filter-panel - Add z-index: 5, position: relative, and background: white to .series-panel - This creates proper stacking contexts preventing visual overlap Reverts test workarounds - tests now use standard Playwright .check() since the underlying CSS issue is fixed. Note: The notification permission test still accepts both "Enabled" and "Blocked" outcomes - this is a separate issue where webkit doesn't honor context.grantPermissions() for the Notifications API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.