Skip to content

Commit 1c48422

Browse files
Merge pull request #161 from JaneliaSciComp/splitCorr
Changes in BigStitcher to adapt to splitcorr branch merge
2 parents e5411cf + 067118b commit 1c48422

File tree

13 files changed

+100
-456
lines changed

13 files changed

+100
-456
lines changed

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@
120120
<n5-zarr-version>1.5.0</n5-zarr-version>
121121
-->
122122

123-
<multiview-reconstruction.version>7.0.7</multiview-reconstruction.version>
123+
<multiview-reconstruction.version>8.1.1</multiview-reconstruction.version>
124124

125125
<bigdataviewer-n5.version>1.0.2</bigdataviewer-n5.version>
126126
<mpicbg.mpicbg.version>1.6.5</mpicbg.mpicbg.version>

src/main/java/net/preibisch/stitcher/algorithm/globalopt/ExecuteGlobalOpt.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ public void run()
7676
}
7777

7878
final boolean isSavedFaG = savedFiltering != null;
79-
final GlobalOptimizationParameters params = expertMode ? GlobalOptimizationParameters.askUserForParameters(!isSavedFaG) : GlobalOptimizationParameters.askUserForSimpleParameters();
79+
final GlobalOptimizationParameters params = GlobalOptimizationParameters.askUserForSimpleParameters();
8080
if ( params == null )
8181
return;
8282

src/main/java/net/preibisch/stitcher/algorithm/globalopt/GlobalOptStitcher.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -191,6 +191,7 @@ public List< ViewId > getDefaultFixedViews()
191191
{
192192
HashMap< ViewId, mpicbg.models.Tile< TranslationModel3D > > globalOptResults = GlobalOptTwoRound.computeTiles(
193193
new TranslationModel3D(),
194+
true,// preAlign
194195
new ImageCorrelationPointMatchCreator( results ),
195196
new SimpleIterativeConvergenceStrategy( Double.MAX_VALUE,
196197
params.relativeThreshold, params.absoluteThreshold ),
@@ -222,6 +223,7 @@ else if ( params.method == GlobalOptType.ONE_ROUND_ITERATIVE)
222223
{
223224
HashMap< ViewId, mpicbg.models.Tile< TranslationModel3D > > globalOptResults = GlobalOptIterative.computeTiles(
224225
new TranslationModel3D(),
226+
true,// preAlign
225227
new ImageCorrelationPointMatchCreator( results ),
226228
new SimpleIterativeConvergenceStrategy( Double.MAX_VALUE,
227229
params.relativeThreshold, params.absoluteThreshold ),
@@ -246,6 +248,7 @@ else if ( params.method == GlobalOptType.ONE_ROUND_ITERATIVE)
246248
{
247249
final HashMap< ViewId, mpicbg.models.Tile< TranslationModel3D > > globalOptResults = GlobalOpt.computeTiles(
248250
new TranslationModel3D(),
251+
true,// preAlign
249252
new ImageCorrelationPointMatchCreator( results ),
250253
new SimpleIterativeConvergenceStrategy( Double.MAX_VALUE,
251254
params.relativeThreshold, params.absoluteThreshold ),

src/main/java/net/preibisch/stitcher/algorithm/globalopt/TransformationTools.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -750,6 +750,7 @@ public static void main( String[] args )
750750

751751
GlobalOpt.computeTiles(
752752
new TranslationModel3D(),
753+
true,// preAlign
753754
new ImageCorrelationPointMatchCreator( results, 0.5 ),
754755
new ConvergenceStrategy( 5.0 ),
755756
fixedViews,

src/main/java/net/preibisch/stitcher/gui/StitchingExplorerPanel.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -265,6 +265,15 @@ public boolean illumsGrouped()
265265
return true;
266266
}
267267

268+
@Override
269+
protected void clearGroupingCheckboxes()
270+
{
271+
if ( checkboxGroupChannels != null )
272+
checkboxGroupChannels.setSelected( false );
273+
if ( checkboxGroupIllums != null )
274+
checkboxGroupIllums.setSelected( false );
275+
}
276+
268277

269278

270279
void quitLinkExplorer()

src/main/java/net/preibisch/stitcher/gui/popup/CalculatePCPopupExpertBatch.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,10 @@
3131
public class CalculatePCPopupExpertBatch extends JMenu implements ExplorerWindowSetable
3232
{
3333

34+
private static final long serialVersionUID = 804355154792175254L;
3435
final CalculatePCPopup phaseCorrSimple;
3536
final CalculatePCPopup phaseCorr;
3637
final CalculatePCPopup lucasKanade;
37-
final PairwiseInterestPointRegistrationPopup interestPoint;
3838
boolean wizardMode;
3939

4040
public CalculatePCPopupExpertBatch( String description, boolean wizardMode )
@@ -50,13 +50,11 @@ public CalculatePCPopupExpertBatch( String description, boolean wizardMode )
5050

5151
phaseCorr = new CalculatePCPopup( wizardMode ? "Phase Correlation" : "Phase Correlation (expert)", false, Method.PHASECORRELATION, wizardMode );
5252
lucasKanade = new CalculatePCPopup( "Lucas-Kanade", false, Method.LUCASKANADE, wizardMode );
53-
interestPoint = new PairwiseInterestPointRegistrationPopup( "Interest point based", wizardMode );
5453

5554
if(!wizardMode)
5655
this.add(phaseCorrSimple);
5756
this.add( phaseCorr );
5857
this.add( lucasKanade );
59-
this.add( interestPoint );
6058
}
6159

6260
@Override
@@ -66,7 +64,6 @@ public JComponent setExplorerWindow( ExplorerWindow< ? > panel )
6664
this.phaseCorrSimple.setExplorerWindow( panel );
6765
this.phaseCorr.setExplorerWindow( panel );
6866
this.lucasKanade.setExplorerWindow( panel );
69-
this.interestPoint.setExplorerWindow( panel );
7067
return this;
7168
}
7269

src/main/java/net/preibisch/stitcher/gui/popup/PairwiseInterestPointRegistrationPopup.java

Lines changed: 0 additions & 227 deletions
This file was deleted.

src/main/java/net/preibisch/stitcher/gui/popup/RefineWithICPPopup.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@
3232

3333
import net.preibisch.legacy.io.IOFunctions;
3434
import net.preibisch.mvrecon.fiji.plugin.interestpointregistration.global.GlobalOptimizationParameters;
35+
import net.preibisch.mvrecon.fiji.plugin.interestpointregistration.global.GlobalOptimizationParameters.PreAlign;
3536
import net.preibisch.mvrecon.fiji.plugin.util.MouseOverPopUpStateChanger;
3637
import net.preibisch.mvrecon.fiji.plugin.util.MouseOverPopUpStateChanger.StateChanger;
3738
import net.preibisch.mvrecon.fiji.spimdata.SpimData2;
@@ -243,7 +244,7 @@ public void actionPerformed( ActionEvent e )
243244
if ( !ICPRefinement.getGUIParametersSimple( icpType, data, params, downsamplingChoice, thresholdChoice, distanceChoice ) )
244245
return;
245246

246-
globalOptParams = GlobalOptimizationParameters.getGlobalOptimizationParametersForSelection( GlobalOptimizationParameters.defaultSimple );
247+
globalOptParams = GlobalOptimizationParameters.getGlobalOptimizationParametersForSelection( GlobalOptimizationParameters.defaultSimple, false );
247248
}
248249

249250
if ( globalOptParams == null )

src/main/java/net/preibisch/stitcher/headless/registration/TestGlobalOptTwoRound.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,7 @@ public static void main( String[] args )
148148

149149
final HashMap< ViewId, TranslationModel3D > computeResults = GlobalOptTwoRound.computeModels(
150150
new TranslationModel3D(),
151+
true,// preAlign
151152
pmc,
152153
cs,
153154
new MaxErrorLinkRemoval(),

0 commit comments

Comments
 (0)