Skip to content

Commit 320f788

Browse files
committed
Minimize preprocessor code duplicates
1 parent 684d53b commit 320f788

3 files changed

Lines changed: 16 additions & 36 deletions

File tree

src/client/java/net/irisshaders/imgui/ImGuiMC.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@
55
import com.mojang.blaze3d.opengl.GlDevice;
66
import com.mojang.blaze3d.opengl.GlStateManager;
77
import com.mojang.blaze3d.opengl.GlTexture;
8-
//?} else {
9-
108
//?}
119
import com.mojang.blaze3d.systems.RenderSystem;
1210
import imgui.ImGui;

src/client/java/net/irisshaders/imgui/mixin/DrawMixin.java

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -10,17 +10,9 @@
1010

1111
@Mixin(Minecraft.class)
1212
public class DrawMixin {
13-
//? if >=1.21 {
14-
@Inject(method = "runTick", at = @At(value = "INVOKE", target = "Lnet/minecraft/client/renderer/GameRenderer;render(Lnet/minecraft/client/DeltaTracker;Z)V", shift = At.Shift.AFTER))
13+
@Inject(method = "runTick", at = @At(value = "INVOKE", target = /*? if >= 1.21 {*/"Lnet/minecraft/client/renderer/GameRenderer;render(Lnet/minecraft/client/DeltaTracker;Z)V"/*?} else {*//*"Lnet/minecraft/client/renderer/GameRenderer;render(FJZ)V"*//*?}*/, shift = At.Shift.AFTER))
1514
private void imgui$draw(boolean bl, CallbackInfo ci) {
1615
ImGui.showDemoWindow();
1716
ImGuiMC.getInstance().draw();
1817
}
19-
//?} else {
20-
/*@Inject(method = "runTick", at = @At(value = "INVOKE", target = "Lnet/minecraft/client/renderer/GameRenderer;render(FJZ)V", shift = At.Shift.AFTER))
21-
private void imgui$draw(boolean bl, CallbackInfo ci) {
22-
ImGui.showDemoWindow();
23-
ImGuiMC.getInstance().draw();
24-
}
25-
*///?}
2618
}

src/client/java/net/irisshaders/imgui/mixin/RendererInitMixin.java

Lines changed: 15 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,11 @@
44
import com.mojang.blaze3d.TracyFrameCapture;
55
import com.mojang.blaze3d.shaders.ShaderType;
66
import com.mojang.blaze3d.systems.RenderSystem;
7-
//?} elif >1.21 {
8-
/*import com.mojang.blaze3d.systems.RenderSystem;
9-
*///?} else {
7+
//?} else {
108
/*import com.mojang.blaze3d.systems.RenderSystem;
9+
import net.minecraft.client.Minecraft;
1110
*///?}
1211
import net.irisshaders.imgui.ImGuiMC;
13-
import net.minecraft.client.Minecraft;
1412
import net.minecraft.resources.ResourceLocation;
1513
import org.spongepowered.asm.mixin.Mixin;
1614
import org.spongepowered.asm.mixin.injection.At;
@@ -21,33 +19,25 @@
2119

2220
@Mixin(RenderSystem.class)
2321
public class RendererInitMixin {
24-
//? if =1.21.5 {
2522
@Inject(at = @At("RETURN"), method = "initRenderer", remap = false)
23+
//? if = 1.21.5 {
2624
private static void imgui$initRenderer(long window, int i, boolean bl, BiFunction<ResourceLocation, ShaderType, String> biFunction, boolean bl2, CallbackInfo ci) {
2725
ImGuiMC.getInstance().onRendererInit(window);
2826
}
27+
//?} else {
28+
/*private static void imgui$initRenderer(int i, boolean bl, CallbackInfo ci) {
29+
ImGuiMC.getInstance().onRendererInit(Minecraft.getInstance().getWindow().getWindow());
30+
}
31+
*///?}
32+
2933
@Inject(at = @At("RETURN"), method = "flipFrame", remap = false)
30-
private static void imgui$newFrame(long l, TracyFrameCapture tracyFrameCapture, CallbackInfo ci) {
34+
private static void imgui$newFrame(
35+
long l,
36+
//? if >= 1.21.5
37+
TracyFrameCapture tracyFrameCapture,
38+
CallbackInfo ci
39+
) {
3140
ImGuiMC.getInstance().afterPollEvents(l);
3241
}
33-
//?} elif >1.21 {
34-
/*@Inject(at = @At("RETURN"), method = "initRenderer", remap = false)
35-
private static void imgui$initRenderer(int i, boolean bl, CallbackInfo ci) {
36-
ImGuiMC.getInstance().onRendererInit(Minecraft.getInstance().getWindow().getWindow());
37-
}
38-
@Inject(at = @At("RETURN"), method = "flipFrame", remap = false)
39-
private static void imgui$newFrame(long l, CallbackInfo ci) {
40-
ImGuiMC.getInstance().afterPollEvents(l);
41-
}
42-
*///?} else {
43-
/*@Inject(at = @At("RETURN"), method = "initRenderer", remap = false)
44-
private static void imgui$initRenderer(int i, boolean bl, CallbackInfo ci) {
45-
ImGuiMC.getInstance().onRendererInit(Minecraft.getInstance().getWindow().getWindow());
46-
}
47-
@Inject(at = @At("RETURN"), method = "flipFrame", remap = false)
48-
private static void imgui$newFrame(long l, CallbackInfo ci) {
49-
ImGuiMC.getInstance().afterPollEvents(l);
50-
}
51-
*///?}
5242

5343
}

0 commit comments

Comments
 (0)