Skip to content

gh-1436: Fix incorrectly rejecting trailing comma after **rest#1438

Merged
drinkmorewaterr merged 4 commits intoInstagram:mainfrom
itamaro:gh-1436
Jan 22, 2026
Merged

gh-1436: Fix incorrectly rejecting trailing comma after **rest#1438
drinkmorewaterr merged 4 commits intoInstagram:mainfrom
itamaro:gh-1436

Conversation

@itamaro
Copy link
Copy Markdown
Contributor

@itamaro itamaro commented Jan 18, 2026

fixes #1436

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 18, 2026
@itamaro itamaro marked this pull request as ready for review January 18, 2026 23:21
@itamaro
Copy link
Copy Markdown
Contributor Author

itamaro commented Jan 18, 2026

@drinkmorewaterr CI seems happy with this fix, can you take a look please?

@drinkmorewaterr drinkmorewaterr merged commit 2dc435f into Instagram:main Jan 22, 2026
42 checks passed
jorenham pushed a commit to jorenham/LibCST that referenced this pull request Feb 3, 2026
@itamaro @jorenham
Instagramgh-1436: Fix incorrectly rejecting trailing comma after `**r…
e9b0c8c 
…est` (Instagram#1438)

* Add a unittest to expose the issue reported in Instagramgh-1436

* Fix issue reported in Instagramgh-1436

* formatting

* Add roundtrip tests for trailing comma after `**rest`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drinkmorewaterr drinkmorewaterr drinkmorewaterr approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect error message for valid match/case {**rest,} syntax

2 participants

@itamaro @drinkmorewaterr