SDL1 with keyboard input.

[Hairo]

Is it possible to use the SDL1 driver without touch? i'm trying to using this library for a device that has SDL1 support but no touchscreen and while i can get it to build some of the examples i can't get keyboard input working.

When trying to use DRV_DISP_SDL1 DRV_TOUCH_NONE and GSLC_FEATURE_INPUT 1 i get:

GUIslice/GUIslice.h:75:4: error: #error "CONFIG: DRV_TOUCH_NONE is not compatible with FEATURE_INPUT. Consider selecting DRV_TOUCH_INPUT in GUIslice config"
   75 |   #error "CONFIG: DRV_TOUCH_NONE is not compatible with FEATURE_INPUT. Consider selecting DRV_TOUCH_INPUT in GUIslice config"
      |    ^~~~~

And when trying with DRV_TOUCH_INPUT instead of DRV_TOUCH_NONE above i get:

GUIslice/GUIslice.c: In function ‘gslc_Init’:
GUIslice/GUIslice.c:279:43: error: ‘GSLC_DEV_TOUCH’ undeclared (first use in this function); did you mean ‘GSLC_EVT_TOUCH’?
  279 |       bool bTouchOk = gslc_InitTouch(pGui,GSLC_DEV_TOUCH);
      |                                           ^~~~~~~~~~~~~~
      |                                           GSLC_EVT_TOUCH

This is with the rpi-sdl1-default-sdl.h config example, if i set GSLC_FEATURE_INPUT 0 the examples compile successfully but no input in the device.

[Pconti31]

@Hairo Did you fail to include

 #define DRV_TOUCH_INPUT           // No touchscreen, just GPIO buttons enabled

???
Paul--

[Hairo]

What you mean? i did try with DRV_TOUCH_INPUT and got the second compile error above.

[Pconti31]

@Hairo the first complier erroir is caused by line 75 of GUIslice.h

#if defined(DRV_TOUCH_NONE) && (GSLC_FEATURE_INPUT)
  #error "CONFIG: DRV_TOUCH_NONE is not compatible with FEATURE_INPUT. Consider selecting DRV_TOUCH_INPUT in GUIslice config"
#endif

which means you either used DRV_TOUCH_NONE and GSLC_FEATURE_INPUT instead of
DRV_TOUCH_INPUT and GSLC_FEATURE_INPUT.
The complier can't give this error otherwise.

[Pconti31]

@Hairo Ah! I just saw the second error my bad.
maybe GUIslice.c line 270 should be

  #if defined(DRV_TOUCH_NONE) || defined(DRV_TOUCH_INPUT )

Paul--

[Hairo]

I think there's some sort of misunderstanding, maybe the wording in my first post was not clear enough, but i did try with DRV_TOUCH_INPUT and GSLC_FEATURE_INPUT 1 and got the second compile error.

Here's my full config file:

#ifndef _GUISLICE_CONFIG_LINUX_H_
#define _GUISLICE_CONFIG_LINUX_H_

// =============================================================================
// GUIslice library (example user configuration) for:
//   - CPU:     LINUX Raspberry Pi (RPi)
//   - Display: PiTFT
//   - Touch:   SDL
//   - Wiring:  None
//
// DIRECTIONS:
// - To use this example configuration, include in "GUIslice_config.h"
//
// WIRING:
// - None
//
// =============================================================================
// - Calvin Hass
// - https://github.com/ImpulseAdventure/GUIslice
// =============================================================================
//
// The MIT License
//
// Copyright 2016-2020 Calvin Hass
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
//
// =============================================================================
// \file GUIslice_config_linux.h

// =============================================================================
// User Configuration
// - This file can be modified by the user to match the
//   intended target configuration
// =============================================================================

#ifdef __cplusplus
extern "C" {
#endif // __cplusplus


  // =============================================================================
  // USER DEFINED CONFIGURATION
  // =============================================================================

  // -----------------------------------------------------------------------------
  // SECTION 1: Device Mode Selection
  // - The following defines the display and touch drivers
  //   and should not require modifications for this example config
  // -----------------------------------------------------------------------------
  #define DRV_DISP_SDL1             // LINUX SDL 1.2
  // #define DRV_TOUCH_SDL
  // #define DRV_TOUCH_NONE
  #define DRV_TOUCH_INPUT
  // #define DRV_TOUCH_IN_DISP

  // -----------------------------------------------------------------------------
  // SECTION 2: Pinout
  // -----------------------------------------------------------------------------


  // -----------------------------------------------------------------------------
  // SECTION 3: Orientation
  // -----------------------------------------------------------------------------

  // Set Default rotation of the display
  // - Values 0,1,2,3. Rotation is clockwise
  // NOTE: The GSLC_ROTATE feature is not yet supported in SDL mode
  //       however, the following settings are provided for future use.
  #define GSLC_ROTATE     1

  // -----------------------------------------------------------------------------
  // SECTION 4: Touch Handling
  // - Documentation for configuring touch support can be found at:
  //   https://github.com/ImpulseAdventure/GUIslice/wiki/Configure-Touch-Support
  // -----------------------------------------------------------------------------

  // -----------------------------------------------------------------------------
  // SECTION 5: Diagnostics
  // -----------------------------------------------------------------------------

  // Error reporting
  // - Set DEBUG_ERR to >0 to enable error reporting via the Serial connection
  // - Enabling DEBUG_ERR increases FLASH memory consumption which may be
  //   limited on the baseline Arduino (ATmega328P) devices.
  //   - DEBUG_ERR 0 = Disable all error messaging
  //   - DEBUG_ERR 1 = Enable critical error messaging (eg. init)
  //   - DEBUG_ERR 2 = Enable verbose error messaging (eg. bad parameters, etc.)
  // - For baseline Arduino UNO, recommended to disable this after one has
  //   confirmed basic operation of the library is successful.
  #define DEBUG_ERR               0   // 1,2 to enable, 0 to disable

  // Debug initialization message
  // - By default, GUIslice outputs a message in DEBUG_ERR mode
  //   to indicate the initialization status, even during success.
  // - To disable the messages during successful initialization,
  //   uncomment the following line.
  //#define INIT_MSG_DISABLE

  // -----------------------------------------------------------------------------
  // SECTION 6: Optional Features
  // -----------------------------------------------------------------------------

  // Enable of optional features
  // - For memory constrained devices such as Arduino, it is best to
  //   set the following features to 0 (to disable) unless they are
  //   required.
  #define GSLC_FEATURE_COMPOUND       1   // Compound elements (eg. XSelNum)
  #define GSLC_FEATURE_XTEXTBOX_EMBED 0   // XTextbox control with embedded color
  #define GSLC_FEATURE_INPUT          1   // Keyboard / GPIO input control

  // Enable support for SD card
  // - Set to 1 to enable, 0 to disable
  // - Note that the inclusion of the SD library consumes considerable
  //   RAM and flash memory which could be problematic for Arduino models
  //   with limited resources.
  // - NOTE: Mode not supported in LINUX
  #define GSLC_SD_EN    0


  // =============================================================================
  // SECTION 10: INTERNAL CONFIGURATION
  // - The following settings should not require modification by users
  // =============================================================================

  // -----------------------------------------------------------------------------
  // Touch Handling
  // -----------------------------------------------------------------------------

  // Define the maximum number of touch events that are handled
  // per gslc_Update() call. Normally this can be set to 1 but certain
  // displays may require a greater value (eg. 30) in order to increase
  // responsiveness of the touch functionality.
  #define GSLC_TOUCH_MAX_EVT    1

  // -----------------------------------------------------------------------------
  // Misc
  // -----------------------------------------------------------------------------

  // Enable support for graphics clipping (DrvSetClipRect)
  // - Note that this will impact performance of drawing graphics primitives
  //#define GSLC_CLIP_EN 1

  // Enable for bitmap transparency and definition of color to use
  #define GSLC_BMP_TRANS_EN     1               // 1 = enabled, 0 = disabled
  #define GSLC_BMP_TRANS_RGB    0xFF,0x00,0xFF  // RGB color (default: MAGENTA)

  #define GSLC_USE_FLOAT        1   // 1=Use floating pt library, 0=Fixed-point lookup tables

  // Define default device paths for framebuffer & touchscreen
  #define GSLC_DEV_FB       "/dev/fb0"
  // #define GSLC_DEV_TOUCH    "/dev/input/touchscreen"
  #define GSLC_DEV_VID_DRV  "fbcon"

  // Enable SDL startup workaround? (1 to enable, 0 to disable)
  #define DRV_SDL_FIX_START     0

  // Show SDL mouse (1 to show, 0 to hide)
  #define DRV_SDL_MOUSE_SHOW    0

  #define GSLC_USE_PROGMEM      0

  #define GSLC_LOCAL_STR        1   // 1=Use local strings (in element array), 0=External
  #define GSLC_LOCAL_STR_LEN    30  // Max string length of text elements

  // -----------------------------------------------------------------------------
  // Debug diagnostic modes
  // -----------------------------------------------------------------------------
  // - Uncomment any of the following to enable specific debug modes
  //#define DBG_LOG           // Enable debugging log output
  //#define DBG_TOUCH         // Enable debugging of touch-presses
  //#define DBG_FRAME_RATE    // Enable diagnostic frame rate reporting
  //#define DBG_DRAW_IMM      // Enable immediate rendering of drawing primitives
  //#define DBG_DRIVER        // Enable graphics driver debug reporting


  // =============================================================================

#ifdef __cplusplus
}
#endif // __cplusplus
#endif // _GUISLICE_CONFIG_LINUX_H_

[Pconti31]

@Hairo It looks to me like Calvin never tested GPIO pin input without also using a touch driver.
ex22_lnx_input_key.c is using both. However, in looking over the code it looks to me
that it should work.
try adding to your config file:

#define GSLC_DEV_TOUCH    ""

which should allow a compile and give a non-fatal error during init.
Paul--

[ImpulseAdventure]

@Hairo It looks to me like Calvin never tested GPIO pin input without also using a touch driver.

ex22_lnx_input_key.c is using both. However, in looking over the code it looks to me

that it should work.

try adding to your config file:

#define GSLC_DEV_TOUCH    ""

which should allow a complie and give a non-faltal error duting init.

Paul--

Yes, that is definitely possible :)

It would make sense to enable users to drive the GUI with GPIO alone. Thanks for reporting this.