Merge pull request fastfloat#368 from x1sc0/main

lemire · web-flow · commit 9f30728ce94a · 2026-02-23T17:27:16.000-05:00
fix warning C4702: unreachable code
diff --git a/include/fast_float/float_common.h b/include/fast_float/float_common.h
@@ -313,8 +313,6 @@ fastfloat_strncasecmp3(UC const *actual_mixedcase,
       return false;
     }
   }
-
-  return true;
 }
 
 template <typename UC>
@@ -369,8 +367,6 @@ fastfloat_strncasecmp5(UC const *actual_mixedcase,
       return false;
     }
   }
-
-  return true;
 }
 
 // Compares two ASCII strings in a case insensitive manner.

Original file line number	Diff line number	Diff line change
`@@ -313,8 +313,6 @@ fastfloat_strncasecmp3(UC const *actual_mixedcase,`
`313`	`313`	`return false;`
`314`	`314`	`}`
`315`	`315`	`}`
`316`		`-`
`317`		`- return true;`
`318`	`316`	`}`
`319`	`317`
`320`	`318`	`template <typename UC>`
`@@ -369,8 +367,6 @@ fastfloat_strncasecmp5(UC const *actual_mixedcase,`
`369`	`367`	`return false;`
`370`	`368`	`}`
`371`	`369`	`}`
`372`		`-`
`373`		`- return true;`
`374`	`370`	`}`
`375`	`371`
`376`	`372`	`// Compares two ASCII strings in a case insensitive manner.`