fix: update collectionId to Uppercase

Author: ChengShi-1

docs/useCases.md

@@ -2810,11 +2810,11 @@ Returns all [Guestbook](../src/guestbooks/domain/models/Guestbook.ts) entries av
 ##### Example call:
 
 ```typescript
-import { getGuestbooksBycollectionId } from '@iqss/dataverse-client-javascript'
+import { getGuestbooksByCollectionId } from '@iqss/dataverse-client-javascript'
 
 const collectionIdOrAlias = 'root'
 
-getGuestbooksBycollectionId.execute(collectionIdOrAlias).then((guestbooks: Guestbook[]) => {
+getGuestbooksByCollectionId.execute(collectionIdOrAlias).then((guestbooks: Guestbook[]) => {
   /* ... */
 })
 ```

src/guestbooks/domain/repositories/IGuestbooksRepository.ts

@@ -7,7 +7,7 @@ export interface IGuestbooksRepository {
     guestbook: CreateGuestbookDTO
   ): Promise<void>
   getGuestbook(guestbookId: number): Promise<Guestbook>
-  getGuestbooksBycollectionId(collectionIdOrAlias: number | string): Promise<Guestbook[]>
+  getGuestbooksByCollectionId(collectionIdOrAlias: number | string): Promise<Guestbook[]>
   setGuestbookEnabled(
     collectionIdOrAlias: number | string,
     guestbookId: number,

src/guestbooks/domain/useCases/GetGuestbooksByCollectionId.ts

@@ -12,6 +12,6 @@ export class GetGuestbooksByCollectionId implements UseCase<Guestbook[]> {
    * @returns {Promise<Guestbook[]>}
    */
   async execute(collectionIdOrAlias: number | string): Promise<Guestbook[]> {
-    return await this.guestbooksRepository.getGuestbooksBycollectionId(collectionIdOrAlias)
+    return await this.guestbooksRepository.getGuestbooksByCollectionId(collectionIdOrAlias)
   }
 }

src/guestbooks/index.ts

@@ -8,10 +8,10 @@ const guestbooksRepository = new GuestbooksRepository()
 
 const createGuestbook = new CreateGuestbook(guestbooksRepository)
 const getGuestbook = new GetGuestbook(guestbooksRepository)
-const getGuestbooksBycollectionId = new GetGuestbooksByCollectionId(guestbooksRepository)
+const getGuestbooksByCollectionId = new GetGuestbooksByCollectionId(guestbooksRepository)
 const setGuestbookEnabled = new SetGuestbookEnabled(guestbooksRepository)
 
-export { createGuestbook, getGuestbook, getGuestbooksBycollectionId, setGuestbookEnabled }
+export { createGuestbook, getGuestbook, getGuestbooksByCollectionId, setGuestbookEnabled }
 
 export {
   CreateGuestbookDTO,

src/guestbooks/infra/repositories/GuestbooksRepository.ts

@@ -31,7 +31,7 @@ export class GuestbooksRepository extends ApiRepository implements IGuestbooksRe
       })
   }
 
-  public async getGuestbooksBycollectionId(
+  public async getGuestbooksByCollectionId(
     collectionIdOrAlias: number | string
   ): Promise<Guestbook[]> {
     return this.doGet(

test/integration/guestbooks/GuestbooksRepository.test.ts

@@ -85,22 +85,22 @@ describe('GuestbooksRepository', () => {
     })
   })
 
-  describe('getGuestbooksBycollectionId', () => {
+  describe('getGuestbooksByCollectionId', () => {
     test('should list guestbooks for collection', async () => {
       await sut.createGuestbook(testCollectionId, createGuestbookDTO)
-      const actual = await sut.getGuestbooksBycollectionId(testCollectionId)
+      const actual = await sut.getGuestbooksByCollectionId(testCollectionId)
       expect(actual.length).toBeGreaterThan(0)
       createdGuestbookId = actual[0].id as number
     })
 
     test('should list guestbooks for collection by collection alias', async () => {
       await sut.createGuestbook(testCollectionAlias, createGuestbookDTO)
-      const actual = await sut.getGuestbooksBycollectionId(testCollectionAlias)
+      const actual = await sut.getGuestbooksByCollectionId(testCollectionAlias)
       expect(actual.length).toBeGreaterThan(0)
     })
 
     test('should return error when collection does not exist', async () => {
-      await expect(sut.getGuestbooksBycollectionId(999999)).rejects.toThrow(ReadError)
+      await expect(sut.getGuestbooksByCollectionId(999999)).rejects.toThrow(ReadError)
     })
   })
 

test/unit/guestbooks/GetGuestbooksByCollectionId.test.ts

@@ -22,18 +22,18 @@ describe('GetGuestbooksByCollectionId', () => {
 
   test('should return guestbooks for collection', async () => {
     const repository: IGuestbooksRepository = {} as IGuestbooksRepository
-    repository.getGuestbooksBycollectionId = jest.fn().mockResolvedValue(guestbooks)
+    repository.getGuestbooksByCollectionId = jest.fn().mockResolvedValue(guestbooks)
 
     const sut = new GetGuestbooksByCollectionId(repository)
     const actual = await sut.execute(collectionId)
 
-    expect(repository.getGuestbooksBycollectionId).toHaveBeenCalledWith(collectionId)
+    expect(repository.getGuestbooksByCollectionId).toHaveBeenCalledWith(collectionId)
     expect(actual).toEqual(guestbooks)
   })
 
   test('should throw ReadError when repository fails', async () => {
     const repository: IGuestbooksRepository = {} as IGuestbooksRepository
-    repository.getGuestbooksBycollectionId = jest.fn().mockRejectedValue(new ReadError())
+    repository.getGuestbooksByCollectionId = jest.fn().mockRejectedValue(new ReadError())
     const sut = new GetGuestbooksByCollectionId(repository)
 
     await expect(sut.execute(collectionId)).rejects.toThrow(ReadError)