fix: depends on reviews

Author: ChengShi-1

test/functional/templates/SetTemplateAsDefault.test.ts

@@ -4,8 +4,7 @@ import { TestConstants } from '../../testHelpers/TestConstants'
 import {
   createTemplate,
   getTemplatesByCollectionId,
-  setTemplateAsDefault,
-  unsetTemplateAsDefault
+  setTemplateAsDefault
 } from '../../../src/templates'
 import { CreateTemplateDTO } from '../../../src/templates/domain/dtos/CreateTemplateDTO'
 import { MetadataFieldTypeClass } from '../../../src/metadataBlocks/domain/models/MetadataBlock'
@@ -56,10 +55,6 @@ describe('SetTemplateAsDefault.execute', () => {
       ]
     }
 
-    const templatesBefore = await getTemplatesByCollectionId.execute(collectionIdOrAlias)
-    const originalDefaultTemplateId =
-      templatesBefore.find((template) => template.isDefault)?.id ?? null
-
     await createTemplate.execute(templateDto, collectionIdOrAlias)
     const templatesAfterCreate = await getTemplatesByCollectionId.execute(collectionIdOrAlias)
     const createdTemplate = templatesAfterCreate.find((template) => template.name === templateName)
@@ -75,12 +70,6 @@ describe('SetTemplateAsDefault.execute', () => {
 
     expect(updatedTemplate?.isDefault).toBe(true)
 
-    if (originalDefaultTemplateId && originalDefaultTemplateId !== createdTemplate.id) {
-      await setTemplateAsDefault.execute(originalDefaultTemplateId, collectionIdOrAlias)
-    } else if (!originalDefaultTemplateId) {
-      await unsetTemplateAsDefault.execute(collectionIdOrAlias)
-    }
-
     await deleteDatasetTemplateViaApi(createdTemplate.id)
   })
 })

test/functional/templates/UnsetTemplateAsDefault.test.ts

@@ -56,10 +56,6 @@ describe('UnsetTemplateAsDefault.execute', () => {
       ]
     }
 
-    const templatesBefore = await getTemplatesByCollectionId.execute(collectionIdOrAlias)
-    const originalDefaultTemplateId =
-      templatesBefore.find((template) => template.isDefault)?.id ?? null
-
     await createTemplate.execute(templateDto, collectionIdOrAlias)
     const templatesAfterCreate = await getTemplatesByCollectionId.execute(collectionIdOrAlias)
     const createdTemplate = templatesAfterCreate.find((template) => template.name === templateName)
@@ -76,10 +72,6 @@ describe('UnsetTemplateAsDefault.execute', () => {
 
     expect(hasDefaultTemplate).toBe(false)
 
-    if (originalDefaultTemplateId && originalDefaultTemplateId !== createdTemplate.id) {
-      await setTemplateAsDefault.execute(originalDefaultTemplateId, collectionIdOrAlias)
-    }
-
     await deleteDatasetTemplateViaApi(createdTemplate.id)
   })
 })

test/integration/templates/TemplateRepository.test.ts

@@ -249,6 +249,9 @@ describe('TemplatesRepository', () => {
 
   describe('setTemplateAsDefault', () => {
     test('should set a template as default for a collection', async () => {
+      const existingTemplates = await getTemplatesByCollectionId.execute(testCollectionAlias)
+      const previousDefaultTemplate = existingTemplates.find((template) => template.isDefault)
+      const previousDefaultTemplateId = previousDefaultTemplate?.id
       await createTemplate.execute(
         {
           name: 'Template for setTemplateAsDefault',
@@ -294,7 +297,11 @@ describe('TemplatesRepository', () => {
 
       expect(updatedTemplate?.isDefault).toBe(true)
 
-      await deleteDatasetTemplateViaApi(templateId)
+      if (previousDefaultTemplateId !== undefined) {
+        await sut.setTemplateAsDefault(testCollectionAlias, previousDefaultTemplateId)
+      } else {
+        await sut.unsetTemplateAsDefault(testCollectionAlias)
+      }
     })
 
     test('should return error when template does not exist', async () => {
@@ -343,6 +350,12 @@ describe('TemplatesRepository', () => {
       const templateId = templates[templates.length - 1].id
 
       await sut.setTemplateAsDefault(testCollectionAlias, templateId)
+      const templatesSetAsDefault = await getTemplatesByCollectionId.execute(testCollectionAlias)
+      const templateSetAsDefault = templatesSetAsDefault.find(
+        (template) => template.id === templateId
+      )
+      expect(templateSetAsDefault?.isDefault).toBe(true)
+
       await sut.unsetTemplateAsDefault(testCollectionAlias)
 
       const templatesAfter = await getTemplatesByCollectionId.execute(testCollectionAlias)