Merge application-form-links-new-window.js in to application-form.js.

Author: frjo

hypha/apply/funds/templates/funds/application_base.html

@@ -89,7 +89,6 @@ <h3>{% blocktrans %}Sorry this {{ page|verbose_name }} is not accepting applicat
     <script src="{% static 'js/application-form.js' %}"></script>
     <script src="{% static 'js/tinymce-word-count.js' %}"></script>
     <script src="{% static 'js/submission-form-copy.js' %}"></script>
-    <script src="{% static 'js/application-form-links-new-window.js' %}"></script>
     {% if not show_all_group_fields %}
         <script src="{% static 'js/form-group-toggle.js' %}"></script>
     {% endif %}

hypha/apply/funds/templates/funds/applicationsubmission_form.html

@@ -45,10 +45,10 @@
 {% endblock %}
 
 {% block extra_js %}
+    <script src="{% static 'js/application-form.js' %}"></script>
     <script src="{% static 'js/tinymce-word-count.js' %}"></script>
     <script src="{% static 'js/multi-input-fields.js' %}"></script>
     <script src="{% static 'js/submission-form-copy.js' %}"></script>
-    <script src="{% static 'js/application-form-links-new-window.js' %}"></script>
     {% if not show_all_group_fields %}
         <script src="{% static 'js/form-group-toggle.js' %}"></script>
     {% endif %}

hypha/apply/projects/templates/application_projects/project_approval_form.html

@@ -102,7 +102,6 @@ <h5>{% trans "Proposal attachments" %}</h5>
     {{ paf_form.media.js }}
     <script src="{% static 'js/tinymce-word-count.js' %}"></script>
     <script src="{% static 'js/multi-input-fields.js' %}"></script>
-    <script src="{% static 'js/application-form-links-new-window.js' %}"></script>
     {% if not show_all_group_fields %}
         <script src="{% static 'js/form-group-toggle.js' %}"></script>
     {% endif %}

hypha/static_src/javascript/application-form-links-new-window.js

@@ -1,10 +1,17 @@
 (function () {
   const form = document.querySelector(".application-form");
+  const links = form.querySelectorAll("a");
   const button = form.querySelector("[type=submit]");
   const required = form.querySelectorAll("input[required]");
   const groups = form.querySelectorAll(".form__group");
   const errors = form.querySelectorAll(".form__error");
 
+  // Make links on application forms open in a new window/tab.
+  links.forEach(function (link) {
+    link.setAttribute("target", "_blank");
+    link.setAttribute("rel", "noopener noreferrer");
+  });
+
   // Set aria-required attribute true for required fields.
   required.forEach(function (field) {
     field.setAttribute("aria-required", true);