C++11 std mutex and condition variable (#1298)

* Add new mutex and condition types

* Update c functions to use new impl

* recursive mutex

* Update src/hx/thread/ConditionVariable.cpp

Co-authored-by: Zeta <53486764+Apprentice-Alchemist@users.noreply.github.com>

* Non recursive mutex for condition variable

* Remove timed wait which isn't actually used anywhere

* Revert "Remove timed wait which isn't actually used anywhere"

This reverts commit 63ea825.

* Use an atomic_int for the thread id

* Update telemetry implementations to use std::mutex

* std::mutex for __hxcpp_field_to_id

* std::mutex for profiler

* std::mutex for debugging

* std::mutex for gc

* try recursive mutex for telemetry

* Revert "std::mutex for gc"

This reverts commit 33ea04d.

* std::mutex for finaliser and root protection

* std::mutex for large object heap

* recursive mutex for special object and state change locks

* pointers to condition variables

* Use wait overload instead of manual while loops

* non recursive mutex for thread pool lock

* non recursive mutex for special object lock

* non recursive mutex for state change lock

* Remove function not used in haxe

---------

Co-authored-by: Aidan Lee <aidan.lee@evcam.com>
Co-authored-by: Zeta <53486764+Apprentice-Alchemist@users.noreply.github.com>

Author: 3 people

include/hx/thread/ConditionVariable.hpp

@@ -0,0 +1,30 @@
+#pragma once
+
+#ifndef HXCPP_H
+#include <hxcpp.h>
+#endif
+
+HX_DECLARE_CLASS2(hx, thread, ConditionVariable)
+
+namespace hx
+{
+	namespace thread
+	{
+		struct ConditionVariable_obj : public hx::Object
+		{
+			ConditionVariable_obj();
+
+			void acquire();
+			bool tryAcquire();
+			void release();
+			void wait();
+			void signal();
+			void broadcast();
+
+		private:
+			struct Impl;
+
+			Impl* impl;
+		};
+	}
+}

include/hx/thread/RecursiveMutex.hpp

@@ -0,0 +1,27 @@
+#pragma once
+
+#ifndef HXCPP_H
+#include <hxcpp.h>
+#endif
+
+HX_DECLARE_CLASS2(hx, thread, RecursiveMutex)
+
+namespace hx
+{
+	namespace thread
+	{
+		struct RecursiveMutex_obj : public hx::Object
+		{
+			RecursiveMutex_obj();
+
+			void acquire();
+			void release();
+			bool tryAcquire();
+
+		private:
+			struct Impl;
+
+			Impl* impl;
+		};
+	}
+}

src/hx/Debug.cpp

@@ -8,6 +8,7 @@
 #include <hx/Telemetry.h>
 #include <hx/Unordered.h>
 #include <hx/OS.h>
+#include <mutex>
 
 
 #if defined(HXCPP_CATCH_SEGV) && !defined(_MSC_VER)
@@ -45,7 +46,7 @@ namespace hx
 const char* EXTERN_CLASS_NAME = "extern";
 
 #ifdef HXCPP_STACK_IDS
-static HxMutex sStackMapMutex;
+static std::mutex sStackMapMutex;
 typedef UnorderedMap<int, StackContext *> StackMap;
 static StackMap sStackMap;
 #endif
@@ -245,9 +246,10 @@ void StackContext::onThreadAttach()
    #ifdef HXCPP_STACK_IDS
    mThreadId = __hxcpp_GetCurrentThreadNumber();
 
-   sStackMapMutex.Lock();
-   sStackMap[mThreadId] = this;
-   sStackMapMutex.Unlock();
+   {
+       std::lock_guard<std::mutex> guard(sStackMapMutex);
+       sStackMap[mThreadId] = this;
+   }
    #endif
 
    #ifdef HXCPP_DEBUGGER
@@ -302,9 +304,10 @@ void StackContext::onThreadDetach()
    #endif
 
    #ifdef HXCPP_STACK_IDS
-   sStackMapMutex.Lock();
-   sStackMap.erase(mThreadId);
-   sStackMapMutex.Unlock();
+   {
+       std::lock_guard<std::mutex> guard(sStackMapMutex);
+       sStackMap.erase(mThreadId);
+   }
    mThreadId = 0;
    #endif
 
@@ -317,18 +320,17 @@ void StackContext::onThreadDetach()
 void StackContext::getAllStackIds( QuickVec<int> &outIds )
 {
    outIds.clear();
-   sStackMapMutex.Lock();
+
+   std::lock_guard<std::mutex> guard(sStackMapMutex);
+
    for(StackMap::iterator i=sStackMap.begin(); i!=sStackMap.end(); ++i)
       outIds.push(i->first);
-   sStackMapMutex.Unlock();
 }
 
 StackContext *StackContext::getStackForId(int id)
 {
-   sStackMapMutex.Lock();
-   StackContext *result = sStackMap[id];
-   sStackMapMutex.Unlock();
-   return result;
+   std::lock_guard<std::mutex> guard(sStackMapMutex);
+   return sStackMap[id];
 }
 #endif