Move "Dumb" test objects to base file

Tests should not directly use abstract classes, but now use basic implementation instead

Author: Lotram

tests/base.py

@@ -2,15 +2,55 @@
 import os.path
 import shutil
 import tempfile
+import typing
 import unittest
 
 import pytest
 import responses
 
-from bugwarrior import config
+from bugwarrior import config, services
 from bugwarrior.config import schema
 
 
+class DumbConfig(config.ServiceConfig):
+    service: typing.Literal["test"] = "test"
+
+    import_labels_as_tags: bool = False
+    label_template: str = "{{label}}"
+
+    @property
+    def service_class(cls) -> type["DumbService"]:
+        return DumbService
+
+
+class DumbIssue(services.Issue):
+    UDAS: dict = {}
+    UNIQUE_KEY: tuple[str, ...] = ("id",)
+    PRIORITY_MAP: dict = {}
+
+    def get_default_description(self):
+        raise NotImplementedError
+
+    def to_taskwarrior(self):
+        raise NotImplementedError
+
+
+class DumbService(services.Service):
+    API_VERSION = 1.0
+    ISSUE_CLASS = DumbIssue
+    CONFIG_SCHEMA = DumbConfig
+
+    @staticmethod
+    def get_keyring_service(_):
+        raise NotImplementedError
+
+    def get_owner(self, _):
+        raise NotImplementedError
+
+    def issues(self):
+        raise NotImplementedError
+
+
 class AbstractServiceTest(abc.ABC):
     """Ensures that certain test methods are implemented for each service."""
 

tests/config/test_schema.py

@@ -10,7 +10,7 @@
 
 from bugwarrior.config import schema
 
-from ..base import ConfigTest
+from ..base import ConfigTest, DumbConfig
 
 
 class TestExpandedPath(unittest.TestCase):
@@ -249,7 +249,7 @@ def test_flavors(self):
 class TestComputeTemplates(unittest.TestCase):
     def test_template(self):
         raw_values = {'templates': {}, 'project_template': 'foo'}
-        computed_values = schema.ServiceConfig().compute_templates(raw_values)
+        computed_values = DumbConfig.compute_templates(raw_values)
         self.assertEqual(computed_values['templates'], {'project': 'foo'})
 
     def test_empty_template(self):
@@ -262,7 +262,7 @@ def test_empty_template(self):
         https://github.com/ralphbean/bugwarrior/issues/970
         """
         raw_values = {'templates': {}, 'project_template': ''}
-        computed_values = schema.ServiceConfig().compute_templates(raw_values)
+        computed_values = DumbConfig.compute_templates(raw_values)
         self.assertEqual(computed_values['templates'], {'project': ''})
 
 

tests/test_service.py

@@ -1,58 +1,18 @@
 import pathlib
 import re
-import typing
 import unittest.mock
 
-from bugwarrior import config, services
+from bugwarrior import services
 from bugwarrior.config import schema
 
-from .base import ConfigTest
+from .base import ConfigTest, DumbService
 
 LONG_MESSAGE = """\
 Some message that is over 100 characters. This message is so long it's
 going to fill up your floppy disk taskwarrior backup. Actually it's not
 that long.""".replace('\n', ' ')
 
 
-class DumbConfig(config.ServiceConfig):
-    service: typing.Literal['test']
-
-    import_labels_as_tags: bool = False
-    label_template: str = '{{label}}'
-
-
-class DumbIssue(services.Issue):
-    """
-    Implement the required methods but they shouldn't be called.
-    """
-
-    def get_default_description(self):
-        raise NotImplementedError
-
-    def to_taskwarrior(self):
-        raise NotImplementedError
-
-
-class DumbService(services.Service):
-    """
-    Implement the required methods but they shouldn't be called.
-    """
-
-    API_VERSION = 1.0
-    ISSUE_CLASS = DumbIssue
-    CONFIG_SCHEMA = DumbConfig
-
-    @staticmethod
-    def get_keyring_service(_):
-        raise NotImplementedError
-
-    def get_owner(self, _):
-        raise NotImplementedError
-
-    def issues(self):
-        raise NotImplementedError
-
-
 class ServiceBase(ConfigTest):
     def setUp(self):
         super().setUp()

tests/test_templates.py

@@ -1,8 +1,7 @@
 from bugwarrior.collect import TaskConstructor
-from bugwarrior.config.schema import MainSectionConfig, ServiceConfig
+from bugwarrior.config.schema import MainSectionConfig
 
-from .base import ServiceTest
-from .test_service import DumbIssue
+from .base import DumbConfig, DumbIssue, ServiceTest
 
 
 class TestTemplates(ServiceTest):
@@ -14,7 +13,7 @@ def setUp(self):
     def get_issue(self, templates=None, issue=None, description=None, add_tags=None):
         templates = {} if templates is None else templates
         template_kwargs = {f'{key}_template': value for key, value in templates.items()}
-        config = ServiceConfig(
+        config = DumbConfig(
             target='dummy', add_tags=add_tags if add_tags else [], **template_kwargs
         )
         main_config = MainSectionConfig(interactive=False, targets=[])