Fix stockout detection in GCP vm async creation.

PiperOrigin-RevId: 886292409

Author: yuyantingzero

perfkitbenchmarker/providers/gcp/gce_virtual_machine.py

@@ -678,6 +678,7 @@ def __init__(self, vm_spec):
     self.create_disk_strategy = gce_disk_strategies.GetCreateDiskStrategy(
         self, None, 0
     )
+    self.skip_existence_check = False
 
   def _GetNetwork(self):
     """Returns the GceNetwork to use."""
@@ -963,6 +964,7 @@ def _Create(self):
     if 'name' in stdout:
       response = json.loads(stdout)
       self.create_operation_name = response[0]['name']
+      self.skip_existence_check = True
 
     self._ParseCreateErrors(self.create_cmd.rate_limited, stderr, retcode)
     if not self.create_return_time:
@@ -1162,6 +1164,7 @@ def _PostCreate(self):
 
   def _Delete(self):
     """Delete a GCE VM instance."""
+    self.skip_existence_check = False
     delete_cmd = util.GcloudCommand(
         self, 'compute', 'instances', 'delete', self.name
     )
@@ -1192,6 +1195,13 @@ def _Resume(self):
   )
   def _Exists(self):
     """Returns true if the VM exists."""
+    if self.skip_existence_check:
+      # We use async creation for VMs.
+      # If the VM creation process is not yet complete,
+      # but the create operation exists, then we
+      # should skip the VM existence check and move on to checking the
+      # create operation status.
+      return True
     getinstance_cmd = util.GcloudCommand(
         self, 'compute', 'instances', 'describe', self.name
     )

tests/gce_virtual_machine_test.py

@@ -658,6 +658,19 @@ def testCreateRhel9CustomImage(self):
       self.assertEqual(vm_metadata, {**vm_metadata, **expected})
       self.assertNotIn('image_family', vm_metadata)
 
+  def testSkipExistenceCheck(self):
+    vm_class = gce_virtual_machine.Debian11BasedGceVirtualMachine
+    spec = gce_virtual_machine.GceVmSpec(
+        _COMPONENT, machine_type='fake-machine-type'
+    )
+    with PatchCriticalObjects([('[{"name": "fake-operation"}]', '', 0)] * 10):
+      vm = vm_class(spec)  # pytype: disable=not-instantiable
+      vm._CreateDependencies()
+      vm._Create()
+      self.assertTrue(vm.skip_existence_check)
+      vm._Delete()
+      self.assertFalse(vm.skip_existence_check)
+
   def testCosVm(self):
     vm_class = virtual_machine.GetVmClass(provider_info.GCP, os_types.COS)
     spec = gce_virtual_machine.GceVmSpec(