Skip to content

Commit 9e7b235

Browse files
committed
Somewhat fix the builder mess
1 parent 750f432 commit 9e7b235

1 file changed

Lines changed: 36 additions & 34 deletions

File tree

inkymessage/src/main/java/ink/glowing/text/InkyMessage.java

Lines changed: 36 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -375,6 +375,11 @@ class Builder implements AbstractBuilder<InkyMessage> {
375375
return this;
376376
}
377377

378+
@Contract("-> new")
379+
public @NotNull Collection<Replacer> replacers() {
380+
return new HashSet<>(replacers);
381+
}
382+
378383
@Contract("_ -> this")
379384
public @NotNull InkyMessage.Builder replacers(@NotNull Replacer @NotNull ... replacers) {
380385
return replacers(Arrays.asList(replacers));
@@ -432,6 +437,11 @@ class Builder implements AbstractBuilder<InkyMessage> {
432437
return this;
433438
}
434439

440+
@Contract("-> new")
441+
public @NotNull Collection<Placeholder> placeholders() {
442+
return new HashSet<>(placeholders.values());
443+
}
444+
435445
@Contract("_ -> this")
436446
public @NotNull InkyMessage.Builder placeholders(@NotNull Placeholder @NotNull ... placeholders) {
437447
return placeholders(Arrays.asList(placeholders));
@@ -479,26 +489,25 @@ class Builder implements AbstractBuilder<InkyMessage> {
479489
}
480490

481491
@Contract("_ -> this")
482-
public @NotNull InkyMessage.Builder removePlaceholder(@NotNull Placeholder placeholder) {
483-
this.placeholders.put(placeholder.label(), placeholder);
492+
public @NotNull InkyMessage.Builder removePlaceholder(@NotNull String placeholderLabel) {
493+
this.placeholders.remove(placeholderLabel);
484494
return this;
485495
}
486496

487497
@Contract("_ -> this")
488-
public @NotNull InkyMessage.Builder removePlaceholders(@NotNull Placeholder @NotNull ... placeholders) {
489-
return removePlaceholders(Arrays.asList(placeholders));
498+
public @NotNull InkyMessage.Builder removePlaceholders(@NotNull String @NotNull ... placeholderLabels) {
499+
return removePlaceholders(Arrays.asList(placeholderLabels));
490500
}
491501

492502
@Contract("_ -> this")
493-
public @NotNull InkyMessage.Builder removePlaceholders(@NotNull Iterable<? extends @NotNull Placeholder> placeholders) {
494-
for (var placeholder : placeholders) removePlaceholder(placeholder);
503+
public @NotNull InkyMessage.Builder removePlaceholders(@NotNull Iterable<? extends @NotNull String> placeholderLabels) {
504+
for (var placeholderLabel : placeholderLabels) removePlaceholder(placeholderLabel);
495505
return this;
496506
}
497507

498-
@Contract("_ -> this")
499-
public @NotNull InkyMessage.Builder removePlaceholders(@NotNull Map<String, Placeholder> placeholders) {
500-
this.placeholders.putAll(placeholders);
501-
return this;
508+
@Contract("-> new")
509+
public @NotNull Collection<Modifier> modifiers() {
510+
return new HashSet<>(modifiers.values());
502511
}
503512

504513
@Contract("_ -> this")
@@ -548,25 +557,19 @@ class Builder implements AbstractBuilder<InkyMessage> {
548557
}
549558

550559
@Contract("_ -> this")
551-
public @NotNull InkyMessage.Builder removeModifier(@NotNull Modifier modifier) {
552-
this.modifiers.put(modifier.label(), modifier);
560+
public @NotNull InkyMessage.Builder removeModifier(@NotNull String modifierLabel) {
561+
this.modifiers.remove(modifierLabel);
553562
return this;
554563
}
555564

556565
@Contract("_ -> this")
557-
public @NotNull InkyMessage.Builder removeModifiers(@NotNull Modifier @NotNull ... modifiers) {
558-
return removeModifiers(Arrays.asList(modifiers));
559-
}
560-
561-
@Contract("_ -> this")
562-
public @NotNull InkyMessage.Builder removeModifiers(@NotNull Iterable<? extends @NotNull Modifier> modifiers) {
563-
for (var modifier : modifiers) removeModifier(modifier);
564-
return this;
566+
public @NotNull InkyMessage.Builder removeModifiers(@NotNull String @NotNull ... modifierLabels) {
567+
return removeModifiers(Arrays.asList(modifierLabels));
565568
}
566569

567570
@Contract("_ -> this")
568-
public @NotNull InkyMessage.Builder removeModifiers(@NotNull Map<String, Modifier> modifiers) {
569-
this.modifiers.putAll(modifiers);
571+
public @NotNull InkyMessage.Builder removeModifiers(@NotNull Iterable<@NotNull String> modifierLabels) {
572+
for (var modifierLabel : modifierLabels) removeModifier(modifierLabel);
570573
return this;
571574
}
572575

@@ -576,6 +579,11 @@ class Builder implements AbstractBuilder<InkyMessage> {
576579
return this;
577580
}
578581

582+
@Contract("-> new")
583+
public @NotNull Collection<SymbolicStyle> symbolics() {
584+
return new HashSet<>(symbolics.values());
585+
}
586+
579587
@Contract("_ -> this")
580588
public @NotNull InkyMessage.Builder symbolics(@NotNull SymbolicStyle @NotNull ... symbolics) {
581589
return symbolics(Arrays.asList(symbolics));
@@ -617,25 +625,19 @@ class Builder implements AbstractBuilder<InkyMessage> {
617625
}
618626

619627
@Contract("_ -> this")
620-
public @NotNull InkyMessage.Builder removeSymbolic(@NotNull SymbolicStyle symbolic) {
621-
this.symbolics.put(symbolic.symbol(), symbolic);
628+
public @NotNull InkyMessage.Builder removeSymbolic(@NotNull Character symbolicSymbol) {
629+
this.symbolics.remove(symbolicSymbol);
622630
return this;
623631
}
624632

625633
@Contract("_ -> this")
626-
public @NotNull InkyMessage.Builder removeSymbolics(@NotNull SymbolicStyle @NotNull ... symbolics) {
627-
return removeSymbolics(Arrays.asList(symbolics));
628-
}
629-
630-
@Contract("_ -> this")
631-
public @NotNull InkyMessage.Builder removeSymbolics(@NotNull Iterable<? extends @NotNull SymbolicStyle> symbolics) {
632-
for (var symbolic : symbolics) removeSymbolic(symbolic);
633-
return this;
634+
public @NotNull InkyMessage.Builder removeSymbolics(@NotNull Character @NotNull ... symbolicsSymbols) {
635+
return removeSymbolics(Arrays.asList(symbolicsSymbols));
634636
}
635637

636638
@Contract("_ -> this")
637-
public @NotNull InkyMessage.Builder removeSymbolics(@NotNull Map<Character, SymbolicStyle> symbolics) {
638-
this.symbolics.putAll(symbolics);
639+
public @NotNull InkyMessage.Builder removeSymbolics(@NotNull Iterable<? extends @NotNull Character> symbolicSymbols) {
640+
for (var symbolicSymbol : symbolicSymbols) removeSymbolic(symbolicSymbol);
639641
return this;
640642
}
641643

0 commit comments

Comments
 (0)