Fix build warnings with Xcode 26 (#1572)

Author: laevandus

DemoAppSwiftUI/AppleMessageComposerView.swift

@@ -148,7 +148,7 @@ struct AppleMessageComposerView<Factory: ViewFactory>: View, KeyboardReadable {
             )
             .offset(y: viewModel.overlayShown ? 0 : popupSize)
             .opacity(viewModel.overlayShown ? 1 : 0)
-            .animation(.easeInOut(duration: 0.25))
+            .animation(.easeInOut(duration: 0.25), value: viewModel.overlayShown)
         }
         .background(
             GeometryReader { proxy in

Sources/StreamChatSwiftUI/ChatComposer/AttachmentPicker/AttachmentMediaPicker/MediaPickerAssetHandler.swift

@@ -19,6 +19,7 @@ final class MediaPickerAssetHandler: ObservableObject {
 
     private let asset: PHAsset
     private let assetLoader: PhotoAssetLoader
+    private var requestToken: UUID?
 
     var assetType: AssetType {
         asset.mediaType == .video ? .video : .image
@@ -123,19 +124,19 @@ final class MediaPickerAssetHandler: ObservableObject {
     ) {
         // Cancelled requests still report back, so the id is only cleared while it is
         // the one in flight. A synchronous completion is not tracked at all.
-        var isCompleted = false
-        var newRequestId: PHImageRequestID?
-        newRequestId = assetLoader.requestAssetURL(
+        let token = UUID()
+        requestToken = token
+        let newRequestId = assetLoader.requestAssetURL(
             for: asset,
             allowsNetworkAccess: allowsNetworkAccess
         ) { [weak self] url in
-            isCompleted = true
-            if let self, let newRequestId, requestId == newRequestId {
+            if let self, requestToken == token {
                 requestId = nil
+                requestToken = nil
             }
             completion(url)
         }
-        if !isCompleted {
+        if requestToken == token {
             requestId = newRequestId
         }
     }
@@ -165,6 +166,7 @@ final class MediaPickerAssetHandler: ObservableObject {
             assetLoader.cancelRequest(requestId)
             self.requestId = nil
         }
+        requestToken = nil
         loading = false
     }
 

Sources/StreamChatSwiftUI/StreamSwiftyGif/ObjcAssociatedWeakObject.swift

@@ -10,9 +10,6 @@ func objc_getAssociatedWeakObject(_ object: AnyObject, _ key: UnsafeRawPointer)
 }
 
 func objc_setAssociatedWeakObject(_ object: AnyObject, _ key: UnsafeRawPointer, _ value: AnyObject?) {
-    weak var weakValue = value
-    let block: (() -> AnyObject?)? = {
-        return weakValue
-    }
+    let block: (() -> AnyObject?)? = { [weak value] in value }
     objc_setAssociatedObject(object, key, block, .OBJC_ASSOCIATION_COPY)
 }

Sources/StreamChatSwiftUI/Utils/Common/ChatClient+Extensions.swift

@@ -17,14 +17,14 @@ extension ChatClient {
     /// - Returns: The maximum allowed size for the attachment in bytes.
     func maxAttachmentSize(for fileURL: URL, fallbackSize: Int64) -> Int64 {
         let attachmentType = AttachmentType(fileExtension: fileURL.pathExtension)
-        let maxAttachmentSize: Int64? = switch attachmentType {
+        let maxAttachmentSize = switch attachmentType {
         case .image:
-            appSettings?.imageUploadConfig.sizeLimitInBytes
+            appSettings?.imageUploadConfig.sizeLimit
         default:
-            appSettings?.fileUploadConfig.sizeLimitInBytes
+            appSettings?.fileUploadConfig.sizeLimit
         }
         if let maxAttachmentSize, maxAttachmentSize > 0 {
-            return maxAttachmentSize
+            return Int64(maxAttachmentSize)
         } else {
             return fallbackSize
         }

StreamChatSwiftUITests/Infrastructure/Shared/CustomAssertions/AssertAsync.swift

@@ -281,10 +281,10 @@ extension Assert {
         file: StaticString = #file,
         line: UInt = #line
     ) -> Assertion {
-        weak var weakObject: T? = object
+        let weakObject = { [weak object] in object }
         object = nil
 
-        return willBeNil(weakObject, message: "Failed to be released from the memory.", file: file, line: line)
+        return willBeNil(weakObject(), message: "Failed to be released from the memory.", file: file, line: line)
     }
 }
 

StreamChatSwiftUITests/Tests/ChatChannel/ChatChannelView_Tests.swift

@@ -247,7 +247,10 @@ import XCTest
         let controller = emptyChannelController()
 
         // When
-        let view = emptyChannelViewWithTypingUser(for: controller)
+        let view = emptyChannelViewWithTypingUser(
+            for: controller,
+            viewFactory: DefaultViewFactory.shared
+        )
 
         // Then
         assertSnapshot(matching: view, as: .image(perceptualPrecision: precision))
@@ -263,7 +266,10 @@ import XCTest
         let controller = emptyChannelController()
 
         // When
-        let view = emptyChannelViewWithTypingUser(for: controller)
+        let view = emptyChannelViewWithTypingUser(
+            for: controller,
+            viewFactory: DefaultViewFactory.shared
+        )
 
         // Then
         assertSnapshot(matching: view, as: .image(perceptualPrecision: precision))
@@ -342,7 +348,7 @@ import XCTest
 
     private func emptyChannelViewWithTypingUser<Factory: ViewFactory>(
         for controller: ChatChannelController_Mock,
-        viewFactory: Factory = DefaultViewFactory.shared
+        viewFactory: Factory
     ) -> some SwiftUI.View {
         let viewModel = ChatChannelViewModel(channelController: controller)
         let typingUser: ChatChannelMember = .mock(id: .unique, name: "Martin")

StreamChatSwiftUITests/Tests/ChatChannel/MessageItemView_Tests.swift

@@ -93,7 +93,7 @@ import XCTest
         let utils = Utils(dateFormatter: EmptyDateFormatter())
         let colors = Appearance.ColorPalette()
         colors.chatTextOutgoing = .red
-        var appearance = Appearance()
+        let appearance = Appearance()
         appearance.colorPalette = colors
         streamChat = StreamChat(chatClient: chatClient, appearance: appearance, utils: utils)
         let message = ChatMessage.mock(
@@ -117,7 +117,7 @@ import XCTest
         let utils = Utils(dateFormatter: EmptyDateFormatter())
         let colors = Appearance.ColorPalette()
         colors.chatTextIncoming = .red
-        var appearance = Appearance()
+        let appearance = Appearance()
         appearance.colorPalette = colors
         streamChat = StreamChat(chatClient: chatClient, appearance: appearance, utils: utils)
         let message = ChatMessage.mock(

StreamChatSwiftUITests/Tests/ChatChannel/MessageView_Tests.swift

@@ -1340,7 +1340,7 @@ import XCTest
         colorPalette.textPrimary = .blue
         colorPalette.chatTextIncoming = .orange
         colorPalette.backgroundCoreElevation1 = .cyan
-        var appearance = Appearance()
+        let appearance = Appearance()
         appearance.colorPalette = colorPalette
         streamChat = StreamChat(
             chatClient: chatClient,

StreamChatSwiftUITests/Tests/ChatChannel/PhotoAssetLoader_Tests.swift

@@ -427,7 +427,7 @@ extension UIImage {
 
 /// Records the requests made by `PhotoAssetLoader` and delivers stubbed results synchronously,
 /// without touching the Photos library.
-private final class PHImageManager_Mock: PHImageManager {
+private final class PHImageManager_Mock: PHImageManager, @unchecked Sendable {
     var requestImageCalls = [(asset: PHAsset, targetSize: CGSize, options: PHImageRequestOptions?)]()
     var cancelledRequestIds = [PHImageRequestID]()
     var requestImageDataOptions: PHImageRequestOptions?

StreamChatSwiftUITests/Tests/ChatChannel/WebView_Tests.swift

@@ -12,7 +12,7 @@ class WebView_Tests: StreamChatTestCase {
     private let mockURL = Bundle(for: WebView_Tests.self).url(forResource: "mock", withExtension: "html")!
 
     func test_webView_snapshot() throws {
-        throw XCTSkip("Check it out: https://github.com/pointfreeco/swift-snapshot-testing/issues/625")
+        try XCTSkipIf(true, "Check it out: https://github.com/pointfreeco/swift-snapshot-testing/issues/625")
 
         // Given
         let request = URLRequest(url: mockURL)