My Fork #8
Craig-Macomber
started this conversation in
General
Replies: 1 comment
-
|
I have done the rename, as well as moved the source. My fork now lives in https://github.com/Craig-Macomber/game-tools/tree/main/dicey and I have archived the old repo. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
I have made a lot of changes on my fork of Caith.
I was having a hard time understanding how the history was handled and wanted to have nicer formatted output for my roller.
I refactored it to have separate parse and evaluation steps, and for the evaluation to not mutate anything and instead additively construct a history which can be nicely formatted.
I redesigned how dice are handled, implementing a DiceKind abstraction which is implemented both for normal dice and fudge dice allowing options to work on both with a single implementation.
Now even silly expressions like:
6d6 e5 K3 r2 d2 e6 + 5df k4 e( )work:Doing this however involved rewriting most of the code, and I didn't try and keep the API compatible and dropped support for the optional features like
ova,cdeand cards. Adding a DiceKind for card decks shouldn't be hard.I have some further changes planned as well, like support for variables. At this point I think it makes sense for me to rename my implementation to be its own thing separate from caith (Crediting caith as appropriate). I haven't done this yet, but I likely will soon.
I just wanted to post here, to thank you for your work on caith, and let you know that my modifications exist in-case you are interested in them. If you want, you could integrate my changes back into caith as a version 5.0.0, and maybe even re-implement the features I removed. If you do that, I may re-base my fork on it so any future changes I make would be easier to integrate if desired.
Beta Was this translation helpful? Give feedback.
All reactions