FEAT: Specify input product using producer name#184
Closed
beojan wants to merge 2 commits intoFramework-R-D:mainfrom
Closed
FEAT: Specify input product using producer name#184beojan wants to merge 2 commits intoFramework-R-D:mainfrom
beojan wants to merge 2 commits intoFramework-R-D:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #184 +/- ##
==========================================
+ Coverage 81.13% 81.46% +0.33%
==========================================
Files 116 116
Lines 2083 2083
Branches 332 331 -1
==========================================
+ Hits 1690 1697 +7
+ Misses 255 250 -5
+ Partials 138 136 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
beojan
force-pushed
the
find-product-by-creator-name
branch
from
9816d89 to
bee7fde
Compare
Contributor
Author
|
Closing this PR. Since the prototype has been released we've come up with a more radical change with a new and improved API. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a preliminary solution for #108. Output products still need to be specified as empty strings at this point.
The API for input product specification without a product name is: