Merge branch 'main' into new-product-query

Author: beojan

.github/REUSABLE_WORKFLOWS.md

@@ -21,7 +21,9 @@ inputs:
     required: false
     default: ""
   type-pattern-add:
-    description: "Additional type-to-glob mappings (comma or newline separated, e.g. cpp:*.cc). '.in' variants are added automatically."
+    description: >-
+      Additional type-to-glob mappings (comma or newline separated, e.g. cpp:*.cc). '.in' variants are added
+      automatically.
     required: false
     default: ""
 outputs:
@@ -44,6 +46,7 @@ runs:
         FILE_TYPE: ${{ inputs.file-type }}
         INCLUDE_GLOBS: ${{ inputs.include-globs }}
         TYPE_PATTERN_ADD: ${{ inputs.type-pattern-add }}
+      # yamllint disable rule:line-length
       run: |
         set -euo pipefail
 
@@ -55,9 +58,11 @@ runs:
         DEFAULT_TYPE_PATTERNS[python]=$'*.py'
         DEFAULT_TYPE_PATTERNS[md]=$'*.md'
         DEFAULT_TYPE_PATTERNS[jsonnet]=$'*.jsonnet\n*.libsonnet'
+        DEFAULT_TYPE_PATTERNS[yaml]=$'*.yaml\n*.yml'
         # Types that do not support .in variants for relevance detection
         declare -A NO_IN_VARIANT_TYPES
         NO_IN_VARIANT_TYPES[jsonnet]="1"
+        NO_IN_VARIANT_TYPES[yaml]="1"
 
         parse_list() {
           local input="$1"
@@ -208,3 +213,4 @@ runs:
           echo "matched=false" >> "$GITHUB_OUTPUT"
           echo "matched_files=" >> "$GITHUB_OUTPUT"
         fi
+      # yamllint enable

.github/actions/detect-relevant-changes/action.yaml

@@ -39,6 +39,10 @@ inputs:
     description: "The number of times to retry pushing the commit."
     required: false
     default: "6"
+  skip-comment:
+    description: "Skip posting PR comments (for workflow_call usage)"
+    required: false
+    default: "false"
 
 runs:
   using: "composite"
@@ -55,25 +59,36 @@ runs:
         fi
 
     - name: No changes to apply
-      if: steps.check_changes.outputs.changes == 'false' && github.event.pull_request.number
+      if: steps.check_changes.outputs.changes == 'false' && inputs.skip-comment != 'true'
       uses: thollander/actions-comment-pull-request@24bffb9b452ba05a4f3f77933840a6a841d1b32b # v3.0.1
       with:
         message: "No automatic ${{ inputs.tool }} fixes were necessary."
 
     - name: Get PR maintainer_can_modify property
       id: pr-properties
-      if: steps.check_changes.outputs.changes == 'true' && github.event.pull_request.number
+      if: steps.check_changes.outputs.changes == 'true'
       uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
       with:
         script: |
+          // context.issue.number is only available when the root trigger is an
+          // issue_comment event. For workflow_dispatch triggers (and any other
+          // non-PR-comment trigger), default to false so the commit path still
+          // works for same-repo pushes via the first clause of the commit condition.
+          const prNumber = context.issue.number;
+          if (!prNumber) {
+            core.setOutput('maintainer_can_modify', 'false');
+            return;
+          }
           const { data: pr } = await github.rest.pulls.get({
             owner: context.repo.owner,
             repo: context.repo.repo,
-            pull_number: context.issue.number
+            pull_number: prNumber
           });
           core.setOutput('maintainer_can_modify', pr.maintainer_can_modify);
     - name: Commit fixes
-      if: steps.check_changes.outputs.changes == 'true' && (inputs.pr-info-repo == github.repository || steps.pr-properties.outputs.maintainer_can_modify == 'true')
+      if: >-
+        steps.check_changes.outputs.changes == 'true' && (inputs.pr-info-repo == github.repository ||
+        steps.pr-properties.outputs.maintainer_can_modify == 'true')
       id: commit_and_push
       shell: bash
       working-directory: ${{ inputs.working-directory }}
@@ -123,15 +138,21 @@ runs:
         exit 1
 
     - name: Notify of commit
-      if: steps.commit_and_push.conclusion == 'success' && steps.commit_and_push.outputs.pushed == 'true' && github.event.pull_request.number
+      if:
+        steps.commit_and_push.conclusion == 'success' && steps.commit_and_push.outputs.pushed == 'true' &&
+        inputs.skip-comment != 'true'
       uses: thollander/actions-comment-pull-request@24bffb9b452ba05a4f3f77933840a6a841d1b32b # v3.0.1
       with:
+        # yamllint disable rule:line-length
         message: |
           Automatic ${{ inputs.tool }} fixes pushed (commit ${{ steps.commit_and_push.outputs.commit_sha_short || steps.commit_and_push.outputs.commit_sha }}).
           ⚠️ **Note:** Some issues may require manual review and fixing.
+        # yamllint enable
 
     - name: Create patch
-      if: steps.check_changes.outputs.changes == 'true' && inputs.pr-info-repo != github.repository && steps.pr-properties.outputs.maintainer_can_modify != 'true'
+      if: >-
+        steps.check_changes.outputs.changes == 'true' && inputs.pr-info-repo != github.repository &&
+        steps.pr-properties.outputs.maintainer_can_modify != 'true'
       id: create_patch
       shell: bash
       working-directory: ${{ inputs.working-directory }}
@@ -147,9 +168,10 @@ runs:
         path: ${{ inputs.working-directory }}/${{ steps.create_patch.outputs.patch_name }}
 
     - name: Comment with patch instructions
-      if: steps.create_patch.outputs.patch_name && github.event.pull_request.number
+      if: steps.create_patch.outputs.patch_name && inputs.skip-comment != 'true'
       uses: thollander/actions-comment-pull-request@24bffb9b452ba05a4f3f77933840a6a841d1b32b # v3.0.1
       with:
+        # yamllint disable rule:line-length
         message: |
           Automatic fixes are available but could not be applied directly because this PR is from a fork and "Allow edits from maintainers" is not enabled.
           Please apply the patch below to fix the issues:
@@ -162,3 +184,4 @@ runs:
              ```bash
              git commit -am "Apply ${{ inputs.tool }} fixes"
              ```
+        # yamllint enable

.github/actions/handle-fix-commit/action.yaml

@@ -5,7 +5,7 @@ permissions:
   contents: read
   pull-requests: read
 
-on:
+"on":
   pull_request:
   workflow_dispatch:
     inputs:
@@ -42,16 +42,22 @@ on:
         type: string
 
 env:
-  local_checkout_path: ${{ (github.event_name == 'workflow_call' && inputs.checkout-path) || format('{0}-src', github.event.repository.name) }}
+  local_checkout_path:
+    ${{ (github.event_name == 'workflow_call' && inputs.checkout-path) || format('{0}-src',
+    github.event.repository.name) }}
 
 jobs:
   pre-check:
     runs-on: ubuntu-latest
     outputs:
       is_act: ${{ steps.detect_act.outputs.is_act }}
-      ref: ${{ (github.event_name == 'workflow_call' && inputs.ref) || (github.event_name == 'workflow_dispatch' && (github.event.inputs.ref || github.ref)) || github.sha }}
+      ref:
+        ${{ (github.event_name == 'workflow_call' && inputs.ref) || (github.event_name == 'workflow_dispatch' &&
+        (github.event.inputs.ref || github.ref)) || github.sha }}
       repo: ${{ (github.event_name == 'workflow_call' && inputs.repo) || github.repository }}
-      base_sha: ${{ (github.event_name == 'workflow_call' && inputs.pr-base-sha) || github.event.pull_request.base.sha || github.event.before }}
+      base_sha:
+        ${{ (github.event_name == 'workflow_call' && inputs.pr-base-sha) || github.event.pull_request.base.sha ||
+        github.event.before }}
     steps:
       - name: Detect act environment
         id: detect_act
@@ -60,12 +66,10 @@ jobs:
   detect-changes:
     needs: pre-check
     if: >
-      github.event_name != 'workflow_dispatch' &&
-      (
+      github.event_name != 'workflow_dispatch' && (
         github.event_name != 'workflow_call' ||
         (inputs.skip-relevance-check != 'true' && github.event.inputs == null && github.event.comment == null)
-      ) &&
-      needs.pre-check.outputs.is_act != 'true'
+      ) && needs.pre-check.outputs.is_act != 'true'
     runs-on: ubuntu-latest
     permissions:
       contents: read
@@ -107,8 +111,7 @@ jobs:
   actionlint-check:
     needs: [pre-check, detect-changes]
     if: >
-      always() &&
-      (
+      always() && (
         needs.detect-changes.result == 'skipped' ||
         (
           needs.detect-changes.result == 'success' &&
@@ -153,14 +156,11 @@ jobs:
   actionlint-check-skipped:
     needs: [pre-check, detect-changes]
     if: >
-      needs.pre-check.result == 'success' &&
-      github.event_name != 'workflow_dispatch' &&
-      (
+      needs.pre-check.result == 'success' && github.event_name != 'workflow_dispatch' && (
         github.event_name != 'workflow_call' ||
         (inputs.skip-relevance-check != 'true' && github.event.inputs == null && github.event.comment == null)
-      ) &&
-      needs.pre-check.outputs.is_act != 'true' &&
-      (needs.detect-changes.result == 'success' && needs.detect-changes.outputs.has_changes != 'true')
+      ) && needs.pre-check.outputs.is_act != 'true' && (needs.detect-changes.result == 'success' &&
+      needs.detect-changes.outputs.has_changes != 'true')
     runs-on: ubuntu-latest
     permissions:
       contents: read

.github/workflows/actionlint-check.yaml

@@ -1,6 +1,6 @@
 name: Add issues to issues project
 
-on:
+"on":
   issues:
     types:
       - opened

.github/workflows/add-issues.yaml

@@ -5,7 +5,7 @@ permissions:
   contents: read
   pull-requests: read
 
-on:
+"on":
   pull_request:
   workflow_dispatch:
     inputs:
@@ -30,8 +30,7 @@ jobs:
   detect-changes:
     needs: pre-check
     if: >
-      github.event_name != 'workflow_dispatch' &&
-      needs.pre-check.outputs.is_act != 'true'
+      github.event_name != 'workflow_dispatch' && needs.pre-check.outputs.is_act != 'true'
     runs-on: ubuntu-latest
     permissions:
       contents: read
@@ -69,8 +68,7 @@ jobs:
   clang-format-check:
     needs: [pre-check, detect-changes]
     if: >
-      always() &&
-      (
+      always() && (
         needs.detect-changes.result == 'skipped' ||
         (
           needs.detect-changes.result == 'success' &&
@@ -115,10 +113,8 @@ jobs:
   clang-format-check-skipped:
     needs: [pre-check, detect-changes]
     if: >
-      github.event_name != 'workflow_dispatch' &&
-      needs.pre-check.outputs.is_act != 'true' &&
-      needs.detect-changes.result == 'success' &&
-      needs.detect-changes.outputs.has_changes != 'true'
+      github.event_name != 'workflow_dispatch' && needs.pre-check.outputs.is_act != 'true' &&
+      needs.detect-changes.result == 'success' && needs.detect-changes.outputs.has_changes != 'true'
     runs-on: ubuntu-latest
     permissions:
       contents: read