性能优化，尝试减少内存分配

Author: FishGoddess

FUTURE.md

@@ -13,7 +13,7 @@
 
 * [x] 调整 hash 包使用姿势
 * [x] 大规模重构，优化代码使用
-* [ ] 性能优化，尝试减少内存分配
+* [x] 性能优化，尝试减少内存分配
 * [ ] 继续完善单元测试，提升覆盖率到 90%
 
 ### v0.3.x

HISTORY.md

@@ -1,5 +1,11 @@
 ## 📜 历史版本的特性介绍 (Features in old versions)
 
+### v0.4.2-alpha
+
+> 此版本发布于 2024-05-27
+
+* 性能优化，尝试减少内存分配
+
 ### v0.4.1-alpha
 
 > 此版本发布于 2024-05-22

README.en.md

@@ -28,6 +28,7 @@ func EncryptECB(key cryptox.Bytes, padding cryptox.Padding, bs cryptox.Bytes) (c
 		return nil, err
 	}
 
+	bs = bs.Clone()
 	src := padding.Padding(bs, blockSize)
 	dst := src.Clone()
 
@@ -80,6 +81,7 @@ func EncryptCBC(key cryptox.Bytes, iv cryptox.Bytes, padding cryptox.Padding, bs
 		return nil, err
 	}
 
+	bs = bs.Clone()
 	src := padding.Padding(bs, blockSize)
 	dst := src.Clone()
 
@@ -106,6 +108,7 @@ func EncryptCFB(key cryptox.Bytes, iv cryptox.Bytes, padding cryptox.Padding, bs
 		return nil, err
 	}
 
+	bs = bs.Clone()
 	src := padding.Padding(bs, blockSize)
 	dst := src.Clone()
 
@@ -132,6 +135,7 @@ func EncryptOFB(key cryptox.Bytes, iv cryptox.Bytes, padding cryptox.Padding, bs
 		return nil, err
 	}
 
+	bs = bs.Clone()
 	src := padding.Padding(bs, blockSize)
 	dst := src.Clone()
 
@@ -158,6 +162,7 @@ func EncryptCTR(key cryptox.Bytes, iv cryptox.Bytes, padding cryptox.Padding, bs
 		return nil, err
 	}
 
+	bs = bs.Clone()
 	src := padding.Padding(bs, blockSize)
 	dst := src.Clone()
 

README.md

@@ -28,6 +28,7 @@ func EncryptECB(key cryptox.Bytes, padding cryptox.Padding, bs cryptox.Bytes) (c
 		return nil, err
 	}
 
+	bs = bs.Clone()
 	src := padding.Padding(bs, blockSize)
 	dst := src.Clone()
 
@@ -80,6 +81,7 @@ func EncryptCBC(key cryptox.Bytes, iv cryptox.Bytes, padding cryptox.Padding, bs
 		return nil, err
 	}
 
+	bs = bs.Clone()
 	src := padding.Padding(bs, blockSize)
 	dst := src.Clone()
 
@@ -106,6 +108,7 @@ func EncryptCFB(key cryptox.Bytes, iv cryptox.Bytes, padding cryptox.Padding, bs
 		return nil, err
 	}
 
+	bs = bs.Clone()
 	src := padding.Padding(bs, blockSize)
 	dst := src.Clone()
 
@@ -132,6 +135,7 @@ func EncryptOFB(key cryptox.Bytes, iv cryptox.Bytes, padding cryptox.Padding, bs
 		return nil, err
 	}
 
+	bs = bs.Clone()
 	src := padding.Padding(bs, blockSize)
 	dst := src.Clone()
 
@@ -158,6 +162,7 @@ func EncryptCTR(key cryptox.Bytes, iv cryptox.Bytes, padding cryptox.Padding, bs
 		return nil, err
 	}
 
+	bs = bs.Clone()
 	src := padding.Padding(bs, blockSize)
 	dst := src.Clone()
 

aes/aes.go

@@ -28,6 +28,7 @@ func EncryptECBTriple(key cryptox.Bytes, padding cryptox.Padding, bs cryptox.Byt
 		return nil, err
 	}
 
+	bs = bs.Clone()
 	src := padding.Padding(bs, blockSize)
 	dst := src.Clone()
 
@@ -80,6 +81,7 @@ func EncryptCBCTriple(key cryptox.Bytes, iv cryptox.Bytes, padding cryptox.Paddi
 		return nil, err
 	}
 
+	bs = bs.Clone()
 	src := padding.Padding(bs, blockSize)
 	dst := src.Clone()
 
@@ -106,6 +108,7 @@ func EncryptCFBTriple(key cryptox.Bytes, iv cryptox.Bytes, padding cryptox.Paddi
 		return nil, err
 	}
 
+	bs = bs.Clone()
 	src := padding.Padding(bs, blockSize)
 	dst := src.Clone()
 
@@ -132,6 +135,7 @@ func EncryptOFBTriple(key cryptox.Bytes, iv cryptox.Bytes, padding cryptox.Paddi
 		return nil, err
 	}
 
+	bs = bs.Clone()
 	src := padding.Padding(bs, blockSize)
 	dst := src.Clone()
 
@@ -158,6 +162,7 @@ func EncryptCTRTriple(key cryptox.Bytes, iv cryptox.Bytes, padding cryptox.Paddi
 		return nil, err
 	}
 
+	bs = bs.Clone()
 	src := padding.Padding(bs, blockSize)
 	dst := src.Clone()
 

des/des.go

@@ -14,8 +14,6 @@ var (
 )
 
 // Padding paddings and undo paddings to a byte slice.
-// You should know the returned bytes is always cloned from the passed bytes,
-// so they are two different byte slices.
 type Padding interface {
 	Padding(bs Bytes, blockSize int) Bytes
 	UndoPadding(bs Bytes, blockSize int) (Bytes, error)
@@ -24,17 +22,16 @@ type Padding interface {
 type paddingNone struct{}
 
 func (paddingNone) Padding(bs Bytes, blockSize int) Bytes {
-	return bs.Clone()
+	return bs
 }
 
 func (paddingNone) UndoPadding(bs Bytes, blockSize int) (Bytes, error) {
-	return bs.Clone(), nil
+	return bs, nil
 }
 
 type paddingZero struct{}
 
 func (paddingZero) Padding(bs Bytes, blockSize int) Bytes {
-	bs = bs.Clone()
 	padding := blockSize - (len(bs) % blockSize)
 
 	for i := 0; i < padding; i++ {
@@ -45,7 +42,6 @@ func (paddingZero) Padding(bs Bytes, blockSize int) Bytes {
 }
 
 func (paddingZero) UndoPadding(bs Bytes, blockSize int) (Bytes, error) {
-	bs = bs.Clone()
 	length := len(bs)
 
 	var i int
@@ -66,7 +62,6 @@ func (paddingZero) UndoPadding(bs Bytes, blockSize int) (Bytes, error) {
 type paddingPKCS7 struct{}
 
 func (paddingPKCS7) Padding(bs Bytes, blockSize int) Bytes {
-	bs = bs.Clone()
 	padding := blockSize - (len(bs) % blockSize)
 
 	for i := 0; i < padding; i++ {
@@ -77,7 +72,6 @@ func (paddingPKCS7) Padding(bs Bytes, blockSize int) Bytes {
 }
 
 func (paddingPKCS7) UndoPadding(bs Bytes, blockSize int) (Bytes, error) {
-	bs = bs.Clone()
 	length := len(bs)
 	number := int(bs[length-1])