Fix #669: CBOR, string ref (#670)

Author: cowtowncoder

cbor/src/main/java/tools/jackson/dataformat/cbor/CBORFactory.java

@@ -269,10 +269,10 @@ protected JsonGenerator _createGenerator(ObjectWriteContext writeCtxt,
                 writeCtxt.getStreamWriteFeatures(_streamWriteFeatures),
                 writeCtxt.getFormatWriteFeatures(_formatWriteFeatures),
                 out);
-        if (CBORWriteFeature.WRITE_TYPE_HEADER.enabledIn(_formatWriteFeatures)) {
+        if (gen.isEnabled(CBORWriteFeature.WRITE_TYPE_HEADER)) {
             gen.writeTag(CBORConstants.TAG_ID_SELF_DESCRIBE);
         }
-        if (CBORWriteFeature.STRINGREF.enabledIn(_formatWriteFeatures)) {
+        if (gen.isEnabled(CBORWriteFeature.STRINGREF)) {
             gen.writeTag(CBORConstants.TAG_ID_STRINGREF_NAMESPACE);
         }
         return gen;

cbor/src/test/java/tools/jackson/dataformat/cbor/StringRef599Test.java

@@ -1,6 +1,7 @@
 package tools.jackson.dataformat.cbor;
 
 import java.util.Arrays;
+import java.util.List;
 
 import org.junit.jupiter.api.Test;
 
@@ -32,6 +33,19 @@ public void testDupsWithStringRef() throws Exception
         _testStringRef(REF_MAPPER);
     }
 
+    // [dataformats-binary#669]: STRINGREF enabled via mapper builder (not factory builder)
+    @Test
+    public void testDupsWithStringRefViaMapperBuilder() throws Exception
+    {
+        ObjectMapper mapper = CBORMapper.builder()
+                .enable(CBORWriteFeature.STRINGREF)
+                .build();
+        List<?> original = Arrays.asList("foo", "foo");
+        byte[] cbor = mapper.writeValueAsBytes(original);
+        List<?> deserialized = mapper.readValue(cbor, List.class);
+        assertEquals(original, deserialized);
+    }
+
     private void _testStringRef(ObjectMapper mapper) throws Exception
     {
         byte[] cbor = mapper.writeValueAsBytes(Arrays.asList("foo", "foo"));

release-notes/CREDITS

@@ -33,3 +33,9 @@ Michael Liedtke (@mcliedtke)
 
 * Contributed #629: (ion) Unnecessary `IOException` in `IonObjectMapper` method signatures
  (3.1.0)
+
+Klaus Meinhardt (@ajafff)
+
+* Reported #669: STRINGREF String reference outside of a namespace
+ (3.1.1)
+

release-notes/VERSION

@@ -21,6 +21,9 @@ No changes since 3.1
 3.1.1 (not yet released)
 
 #387: Avro generator should enforce `StreamWriteConstraints.maxNestingDepth`
+#669: STRINGREF String reference outside of a namespace
+ (reported by Klaus M)
+ (fix by @cowtowncoder, w/ Claude code)
 
 3.1.0 (23-Feb-2026)