refactor(parbase): Improve logging in FairParSet

And re-arrange some if statements

Author: ChristianTackeGSI

fairroot/parbase/FairParSet.cxx

@@ -1,5 +1,5 @@
 /********************************************************************************
- * Copyright (C) 2014-2023 GSI Helmholtzzentrum fuer Schwerionenforschung GmbH  *
+ * Copyright (C) 2014-2024 GSI Helmholtzzentrum fuer Schwerionenforschung GmbH  *
  *                                                                              *
  *              This software is distributed under the terms of the             *
  *              GNU Lesser General Public Licence (LGPL) version 3,             *
@@ -47,30 +47,34 @@ Bool_t FairParSet::init()
     // the second input. If this failes too, it returns an error.
     // (calls internally the init function in the derived class)
     FairRuntimeDb* rtdb = FairRuntimeDb::instance();
-    // FairRunAna* fRun =FairRunAna::Instance();
-    // cout << "-I-  FairParSet::init() " << GetName() << endl;
+    if (!rtdb) {
+        LOG(error) << "FairParSet::init()/" << GetName() << ": No RTDB";
+        return false;
+    }
 
     Bool_t allFound = kFALSE;
-    FairParIo* io = 0;
-    if (rtdb) {
-        io = rtdb->getFirstInput();
+    FairParIo* io = rtdb->getFirstInput();
+    if (io) {
+        allFound = init(io);
+    } else {
+        LOG(warn) << "FairParSet::init()/" << GetName() << ": No first input";
+    }
+    if (!allFound) {
+        io = rtdb->getSecondInput();
+        // cout << "-I FairParSet::init() 2 " << io <<  std::endl;
         if (io) {
             allFound = init(io);
-        }
-        if (!allFound) {
-            io = rtdb->getSecondInput();
-            // cout << "-I FairParSet::init() 2 " << io <<  std::endl;
-            if (io) {
-                allFound = init(io);
-            }
         } else {
-            setInputVersion(-1, 2);
+            LOG(warn) << "FairParSet::init()/" << GetName() << ": No second input";
         }
+    } else {
+        setInputVersion(-1, 2);
     }
+
     if (allFound) {
         return kTRUE;
     }
-    LOG(error) << "init() " << GetName() << " not initialized";
+    LOG(error) << "FairParSet::init()/" << GetName() << ": not initialized";
     return kFALSE;
 }